libefi/time.c cstyle cleanup
ClosedPublic
Actions

Authored by tsoome on Aug 4 2017, 9:57 AM.

Details

Reviewers

imp
eric_metricspace.net

Commits

rS322074: libefi/time.c cstyle cleanup

Summary

The libefi time.c is mix of different styles, lets make it clean.

also, one 0 versus NULL and uninitialized tv struct issue - should those perhaps get their own commits?

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10871
Build 11262: arc lint + arc unit

Event Timeline

tsoome created this revision.Aug 4 2017, 9:57 AM

Harbormaster completed remote builds in B10855: Diff 31563.Aug 4 2017, 9:57 AM

tsoome edited the summary of this revision. (Show Details)Aug 4 2017, 10:00 AM

royger added a subscriber: royger.Aug 4 2017, 1:09 PM

royger added inline comments.

sys/boot/efi/libefi/time.c
268–269	Missing newline, no initialization with declaration.
280	Missing newline

This looks pretty good to me. royger's comments are correct, but I'm not a stickler for that stuff.

Looks like I committed this in pass-through mode. my bad. thanks for cleaning this up.

This revision is now accepted and ready to land.Aug 4 2017, 4:40 PM

Added missing newlines.

This revision now requires review to proceed.Aug 5 2017, 5:03 AM

use memset instead of initializer

Harbormaster completed remote builds in B10871: Diff 31609.Aug 5 2017, 5:16 AM

tsoome marked an inline comment as done.Aug 5 2017, 5:16 AM

Closed by commit rS322074: libefi/time.c cstyle cleanup (authored by tsoome). · Explain WhyAug 5 2017, 5:20 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

boot/

efi/

libefi/

time.c

313 lines

Diff 31609

View Options

sys/boot/efi/libefi/time.c

libefi/time.c cstyle cleanupClosedPublicActions