Backport support for fs_base/gs_base and $_siginfo from GDB master.
ClosedPublic
Actions

Authored by jhb on Aug 1 2017, 9:53 PM.

Details

Reviewers

luca.pizzamiglio_gmail.com
imp

Commits

rP447377: Backport support for fs_base/gs_base and $_siginfo from GDB master.

Summary

Bring in two patchsets committed to GDB master along with a few other commits
those patchsets depend on.

Add support for examining $_siginfo. When a thread has valid signal information, report the current information in a $_siginfo variable. For live processes the values are extracted via the PT_LWPINFO ptrace request. The values are also extracted from process core dumps that include NT_LWPINFO notes (currently only present in FreeBSD 12-current).
Add support for the $fs_base and $gs_base registers on amd64. This only works for live processes via the PT_{GET,SET}{FS,GS}BASE ptrace requests. FreeBSD currently does not store these values in core dumps, so they are not available from core dumps.

Test Plan

Tested new features on FreeBSD/amd64 head.
poudriere testport on 10.3/amd64, 10.3/i386, 11.1/amd64, 12.0/amd64.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 10797
Build 11191: arc lint + arc unit

Event Timeline

jhb created this revision.Aug 1 2017, 9:53 PM

Herald added subscribers: mat, emaste. · View Herald TranscriptAug 1 2017, 9:53 PM

Harbormaster completed remote builds in B10797: Diff 31451.Aug 1 2017, 9:53 PM

It looks good to me. My build and run tests are positive.

This revision is now accepted and ready to land.Aug 4 2017, 3:43 PM

This looks good to me, assuming the patches are good. The ports part looks fine, and listing the patches in order I think will insulate from ordering issues that would otherwise be present.

Closed by commit rP447377: Backport support for fs_base/gs_base and $_siginfo from GDB master. (authored by jhb). · Explain WhyAug 4 2017, 8:16 PM

This revision was automatically updated to reflect the committed changes.