Store dirfd of pidfile.
ClosedPublic
Actions

Authored by oshogbo on Jul 21 2017, 7:13 PM.

Details

Reviewers

Commits

Summary

This allow us to remove pidfile in capability mode thanks to unlinkat(2).

PR: 220524

Lint

Lint Skipped

Unit

Tests Skipped

Regenerate with -U99999.

lib/libutil/pidfile.c
133	Should we try to limit the rights on this descriptor to CAP_UNLINKAT once the pidfile is open? AFAIK this can be done even if the process is not in capability mode. The cap_rights_limit() man page isn't very clear on this though.
170	Seems like we should be careful to preserve errno as you did above?
279	The addition of braces here is inconsistent with the if statement above.

Update diff after markj@ review.

oshogbo marked 2 inline comments as done.Jul 25 2017, 8:34 PM

oshogbo added inline comments.

lib/libutil/pidfile.c
133	I would like to do that in separate commit, is that fine with you?

Works fine in my testing with your flopenat() patch applied as well.

Thanks for addressing this!

lib/libutil/pidfile.c
133	Sure.
252	I would kill this blank line.

This revision is now accepted and ready to land.Jul 25 2017, 9:20 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

libutil/

78 lines