Details
- Reviewers
kib - Commits
- rS276887: ANSIfy sys/fs/msdosfs
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| sys/fs/msdosfs/msdosfs_denode.c | ||
|---|---|---|
| 95 ↗ | (On Diff #3060) | Note comments on individual args removed. I'm not sure they were valuable and largely repeat information in the comment preceding the function anyhow. |
I usually do such changes only with substantial changes, or when changing the affected lines. Reason is that stray formatting/formal commits make $(VCS) blame harder to use.
BTW, why only changing denode.c ? Whole msdosfs uses KR definitions, except functions which I touched (as described above). IMO, if doing the conversion, it is less painful to do it in one step.
I usually do such changes only with substantial changes, or when changing the affected lines. Reason is that stray formatting/formal commits make $(VCS) blame harder to use.
My motivation here is to make it easier to compare our msdosfs with NetBSD. They have a large set of changes (some of which I'd like to import).
BTW, why only changing denode.c ? Whole msdosfs uses KR definitions, except functions which I touched (as described above). IMO, if doing the conversion, it is less painful to do it in one step.
I don't follow - unless I missed something this should be all of msdosfs.
Ok.
BTW, why only changing denode.c ? Whole msdosfs uses KR definitions, except functions which I touched (as described above). IMO, if doing the conversion, it is less painful to do it in one step.
I don't follow - unless I missed something this should be all of msdosfs.
The GUI somehow managed to confuse me yet another time, I only saw denode.