Page MenuHomeFreeBSD

Remove SUBDIR ordering/uniquifying in *bin/Makefile
ClosedPublic

Authored by ngie on Jun 28 2017, 7:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 31 2023, 2:18 PM
Unknown Object (File)
Dec 20 2023, 6:27 AM
Unknown Object (File)
Nov 7 2023, 11:42 AM
Unknown Object (File)
Jul 26 2023, 11:20 PM
Unknown Object (File)
Dec 31 2022, 3:39 AM
Unknown Object (File)
Dec 29 2022, 10:36 AM
Unknown Object (File)
Dec 13 2022, 1:13 PM
Unknown Object (File)
Dec 13 2022, 2:30 AM
Subscribers

Details

Summary

Remove SUBDIR ordering/uniquifying in *bin/Makefile

After the addition of SUBDIR.yes, uniquifying/ordering the SUBDIRs doesn't
make a whole lot of sense, and it's in effect a half measure.

Ordering SUBDIR (after adding SUBDIR.yes to it) in bsd.subdir.mk is a
separate change that warrants more discussion/testing, because while
the SUBDIR_PARALLEL work largely fixed dependency ordering for SUBDIRs,
there might be downstream FreeBSD consumers that rely on the SUBDIR
ordering.

MFC after: 2 months

Test Plan

Need to do a build run on universe12a.freebsd.org

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Seems reasonable to me to respect the ordering of SUBDIR - and we are not ordering in the SUBDIR.yes entries so the current code is not doing much.

This revision is now accepted and ready to land.Jul 5 2017, 7:33 PM
This revision was automatically updated to reflect the committed changes.