Page MenuHomeFreeBSD
Differential D11434

Port PowerPC kqueue(2) compat32 fix in r320500 to MIPS.
ClosedPublic
Actions

Authored by kib on Jul 1 2017, 4:05 AM.
Tags
None
Referenced Files
F107166323: D11434.diff
Sat, Jan 11, 3:31 AM
Unknown Object (File)
Mon, Dec 23, 5:16 PM
Unknown Object (File)
Nov 23 2024, 9:57 PM
Unknown Object (File)
Nov 23 2024, 9:46 PM
Unknown Object (File)
Oct 19 2024, 11:44 PM
Unknown Object (File)
Oct 10 2024, 5:04 PM
Unknown Object (File)
Oct 10 2024, 5:03 PM
Unknown Object (File)
Oct 10 2024, 5:03 PM
View All 26 Files
Subscribers
imp

Details

Reviewers
brooks
jhb
Commits
rS320558: Port PowerPC kqueue(2) compat32 fix in r320500 to MIPS.
Summary

All 32bit MIPS ABIs align uint64_t on 8-byte, according to jhb. Since struct kevent32 is defined using 32bit types to avoid extra alignment on amd64/i386, layout of the structure needs paddings on PowerPC and apparently MIPS.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Jul 1 2017, 4:05 AM
Herald added a subscriber: imp. · View Herald TranscriptJul 1 2017, 4:05 AM
jhb accepted this revision.Jul 1 2017, 4:47 PM
jhb added inline comments.
sys/compat/freebsd32/freebsd32_misc.c
125 ↗(On Diff #30283)

Just checked via gdb on a recent mips o32 libc.so.7 and 'sizeof(struct kevent)' is 64.

This revision is now accepted and ready to land.Jul 1 2017, 4:47 PM
Closed by commit rS320558: Port PowerPC kqueue(2) compat32 fix in r320500 to MIPS. (authored by kib). · Explain WhyJul 1 2017, 10:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
compat/
freebsd32/
4 lines
6 lines

Diff 30308

View Options

head/sys/compat/freebsd32/freebsd32.h

Loading...
View Options

head/sys/compat/freebsd32/freebsd32_misc.c

Loading...