regex(3): Refactor fast/slow stepping bits in the matching engine
ClosedPublic
Actions

Authored by kevans on Jun 16 2017, 3:00 AM.

Details

Reviewers

emaste
cem
pfg

Commits

rS322288: regex(3): Refactor fast/slow stepping bits in the matching engine

Summary

Adding features for matching is fairly straightforward, but requires some
duplication because of this fast/slow setup. They can be fairly trivially combined
into a single walk(), so do it to make it less error prone.

Test Plan

Run regex(3), sed, grep, gsed tests

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9976
Build 10406: arc lint + arc unit

Event Timeline

kevans created this revision.Jun 16 2017, 3:00 AM

Harbormaster completed remote builds in B9925: Diff 29697.Jun 16 2017, 3:00 AM

cem accepted this revision.Jun 17 2017, 7:29 PM

cem added inline comments.

lib/libc/regex/engine.c
868	style nit: spaces around `+`

This revision is now accepted and ready to land.Jun 17 2017, 7:29 PM

Address style nit

This revision now requires review to proceed.Jun 19 2017, 12:57 AM

kevans marked an inline comment as done.Jun 19 2017, 1:01 AM

pfg accepted this revision.Jun 19 2017, 4:52 PM

This revision is now accepted and ready to land.Jun 19 2017, 4:52 PM

emaste added inline comments.Jul 5 2017, 9:29 PM

lib/libc/regex/engine.c
482	walk inside of assert() is OK?

kevans added inline comments.Jul 5 2017, 11:07 PM

lib/libc/regex/engine.c
482	I believe in this case it should be fine; it's a sanity walk that shouldn't alter state since we should have exhausted the substring at that point.