Page MenuHomeFreeBSD
Differential D10659

use the latest waagent 2.2.8
ClosedPublic
Actions

Authored by honzhan_microsoft.com on May 10 2017, 2:38 AM.
Tags
None
Referenced Files
F147812312: D10659.id28221.diff
Fri, Mar 13, 8:50 PM
F147781053: D10659.diff
Fri, Mar 13, 2:54 PM
F147701999: D10659.diff
Fri, Mar 13, 1:26 AM
F147698417: D10659.diff
Fri, Mar 13, 12:37 AM
Unknown Object (File)
Tue, Mar 10, 7:34 AM
Unknown Object (File)
Mon, Mar 9, 10:38 PM
Unknown Object (File)
Sun, Mar 8, 4:56 PM
Unknown Object (File)
Sun, Mar 8, 7:32 AM
View All Files
Subscribers
cem
lifanov

Details

Reviewers
sepherosa_gmail.com
decui_microsoft.com
bapt
gjb
Commits
rP441715: Update to 2.2.8
Summary

This patch wants to update azure-agent and keep tracking the latest waagent. Currently, waagent v2.2.8 passed the Azure test.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

honzhan_microsoft.com created this revision.May 10 2017, 2:38 AM
honzhan_microsoft.com edited the summary of this revision. (Show Details)May 10 2017, 2:43 AM
honzhan_microsoft.com added reviewers: sepherosa_gmail.com, decui_microsoft.com, bapt, gjb.
lifanov added a subscriber: lifanov.May 10 2017, 3:27 PM
lifanov added inline comments.
sysutils/azure-agent/Makefile
4

If you add

DISTVERSIONPREFIX= v

here....

26

.... you can omit GH_TAGNAME here.

honzhan_microsoft.com added inline comments.May 11 2017, 2:15 AM
sysutils/azure-agent/Makefile
4

ok

26

That is good. It makes the file name in distinfo short.

honzhan_microsoft.com updated this revision to Diff 28220.May 11 2017, 2:19 AM
gjb added inline comments.May 11 2017, 2:24 AM
sysutils/azure-agent/pkg-message
6

Please do not recommend this. See the 'shebangfix' section of the Porter's Handbook on how to properly resolve these types of issues:
https://www.freebsd.org/doc/en/books/porters-handbook/uses-shebangfix.html

honzhan_microsoft.com added inline comments.May 11 2017, 2:33 AM
sysutils/azure-agent/pkg-message
6

I'll revise this. Thanks.

honzhan_microsoft.com updated this revision to Diff 28221.May 11 2017, 2:41 AM
honzhan_microsoft.com updated this revision to Diff 28549.May 19 2017, 6:53 AM

Put all installed binary and configuration to $PREFIX (typically /usr/local) folder, then it is not necessary to set symlinks.

Closed by commit rP441715: Update to 2.2.8 (authored by bapt). · Explain WhyMay 25 2017, 8:25 PM
This revision was automatically updated to reflect the committed changes.
cem added a subscriber: cem.Jan 3 2020, 1:45 AM
cem added inline comments.
head/sysutils/azure-agent/Makefile
16 ↗(On Diff #28815)

Any idea why this dependency was added? Python has base64 in its base standard library and it isn't immediately apparent that waagent actually shells out to base64 as a subprocess (or why it would).

Revision Contents
Changeset List

PathSize
sysutils/
azure-agent/
40 lines
4 lines
7 lines

Diff 28549

View Options

sysutils/azure-agent/Makefile

Loading...
View Options

sysutils/azure-agent/distinfo

Loading...
View Options

sysutils/azure-agent/pkg-message

Loading...