Page MenuHomeFreeBSD
Differential D10678

Fix panic in persistent hardware MAC storage
ClosedPublic
Actions

Authored by rpokala on May 11 2017, 6:06 AM.
Tags
None
Referenced Files
F150085791: D10678.id28227.diff
Sun, Mar 29, 6:49 AM
Unknown Object (File)
Fri, Mar 13, 2:30 AM
Unknown Object (File)
Mon, Mar 9, 4:01 PM
Unknown Object (File)
Mon, Mar 9, 10:13 AM
Unknown Object (File)
Mon, Mar 9, 4:22 AM
Unknown Object (File)
Dec 1 2025, 6:25 AM
Unknown Object (File)
Nov 28 2025, 2:46 AM
Unknown Object (File)
Nov 27 2025, 6:44 PM
View All Files
Subscribers
ae
imp

Details

Reviewers
kp
Commits
rS318176: Persistently store NIC's hardware MAC address, and add a way to retrive it
Summary

Add a forgotten NULL-check

Diff Detail

Event Timeline

rpokala created this revision.May 11 2017, 6:06 AM
Herald added subscribers: ae, imp. · View Herald TranscriptMay 11 2017, 6:06 AM
kp edited edge metadata.May 11 2017, 6:20 AM

I think this is correct, but I think you should skip the {}. The rest of the function does not use them for single-line if statements either.

rpokala updated this revision to Diff 28227.May 11 2017, 6:27 AM

The rest of ether_ifattach() foregoes braces for single-line blocks, so
do the same.

kp accepted this revision.May 11 2017, 6:33 AM

I've just done a quick test. The box no longer panics with this patch.

This revision is now accepted and ready to land.May 11 2017, 6:33 AM
Harbormaster completed remote builds in B9189: Diff 28226.May 11 2017, 6:41 AM
rpokala added a comment.May 11 2017, 6:44 AM

Thanks for the review, and sorry about the breakage!

Closed by commit rS318176: Persistently store NIC's hardware MAC address, and add a way to retrive it (authored by rpokala). · Explain WhyMay 11 2017, 6:46 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B9190: Diff 28227.May 11 2017, 7:20 AM

Revision Contents
Changeset List

PathSize
sys/
net/
4 lines

Diff 28226

View Options

sys/net/if_ethersubr.c

Loading...