Differential D10678

Fix panic in persistent hardware MAC storage
ClosedPublic
Actions

Authored by rpokala on May 11 2017, 6:06 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 1, 6:25 AM

	Unknown Object (File)
	Fri, Nov 28, 2:46 AM

	Unknown Object (File)
	Thu, Nov 27, 6:44 PM

	Unknown Object (File)
	Wed, Nov 26, 8:43 AM

	Unknown Object (File)
	Nov 21 2025, 3:45 AM

	Unknown Object (File)
	Nov 21 2025, 3:43 AM

	Unknown Object (File)
	Nov 21 2025, 3:41 AM

	Unknown Object (File)
	Nov 21 2025, 3:41 AM

Subscribers

Details

Reviewers

Commits

rS318176: Persistently store NIC's hardware MAC address, and add a way to retrive it

Summary

Add a forgotten NULL-check

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9189
Build 9634: CI src build	Jenkins
Build 9633: arc lint + arc unit

Event Timeline

rpokala created this revision.May 11 2017, 6:06 AM

Herald added subscribers: ae, imp. · View Herald TranscriptMay 11 2017, 6:06 AM

I think this is correct, but I think you should skip the {}. The rest of the function does not use them for single-line if statements either.

The rest of ether_ifattach() foregoes braces for single-line blocks, so
do the same.

I've just done a quick test. The box no longer panics with this patch.

This revision is now accepted and ready to land.May 11 2017, 6:33 AM

Harbormaster completed remote builds in B9189: Diff 28226.May 11 2017, 6:41 AM

Thanks for the review, and sorry about the breakage!

Closed by commit rS318176: Persistently store NIC's hardware MAC address, and add a way to retrive it (authored by rpokala). · Explain WhyMay 11 2017, 6:46 AM

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B9190: Diff 28227.May 11 2017, 7:20 AM

Revision Contents
Changeset List

Path

Size

sys/

net/

4 lines

Diff 28226

sys/net/if_ethersubr.c

Loading...