Page MenuHomeFreeBSD
Differential D1351

Final removal of WITH_NEW_XORG
ClosedPublic
Actions

Authored by dumbbell on Dec 22 2014, 9:21 AM.
Tags
None
Referenced Files
F103301391: D1351.id2809.diff
Sat, Nov 23, 6:49 AM
Unknown Object (File)
Thu, Nov 21, 1:29 PM
Unknown Object (File)
Wed, Nov 20, 11:27 PM
Unknown Object (File)
Tue, Nov 19, 12:48 AM
Unknown Object (File)
Mon, Nov 18, 9:14 PM
Unknown Object (File)
Sat, Nov 9, 9:12 AM
Unknown Object (File)
Thu, Nov 7, 7:53 AM
Unknown Object (File)
Oct 16 2024, 3:56 PM
View All Files
Subscribers
antoine

Details

Reviewers
antoine
bapt
kwm
Group Reviewers
portmgr
Commits
rP375286: Final removal of WITH_NEW_XORG
Summary

The knob was turned on by default more than two months ago. Since then, it was removed from several places. Now that xserver 1.14 is in the tree, this is the final removal.

While here, add WITH_NEW_XORG and WITH_KMS to bsd.sanity.mk to make people remove them from their /etc/make.conf.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

dumbbell updated this revision to Diff 2809.Dec 22 2014, 9:21 AM
dumbbell retitled this revision from to Final removal of WITH_NEW_XORG.
dumbbell updated this object.
dumbbell edited the test plan for this revision. (Show Details)
dumbbell added a reviewer: kwm.
Herald added a reviewer: portmgr. · View Herald TranscriptDec 22 2014, 9:21 AM
bapt requested changes to this revision.Dec 22 2014, 9:46 AM
bapt added a reviewer: bapt.
This revision now requires changes to proceed.Dec 22 2014, 9:46 AM
kwm requested changes to this revision.Dec 22 2014, 10:30 AM
kwm edited edge metadata.
kwm added inline comments.
x11-servers/xephyr/Makefile
25–26

these lines that where between the .else .endif block needs to be removed too.

kwm added a comment.Dec 22 2014, 10:31 AM

Should there be a ports/CHANGES entry because the switches went away?

bapt added a comment.Dec 22 2014, 10:35 AM

I don't think a changes is needed

dumbbell updated this revision to Diff 2819.Dec 22 2014, 5:17 PM
dumbbell edited edge metadata.

Cleanup x11-servers/xephyr/Makefile: only keep the correct Xephyr.1 man page.

dumbbell added a comment.Dec 22 2014, 5:18 PM
In D1351#9, @kwm wrote:

Should there be a ports/CHANGES entry because the switches went away?

I'm not sure it's necessary, the knob is already ineffective/broken.

antoine accepted this revision.Dec 22 2014, 5:22 PM
antoine added a reviewer: antoine.
antoine added a subscriber: antoine.

Looks good to me

kwm accepted this revision.Dec 22 2014, 8:11 PM
kwm edited edge metadata.
bapt accepted this revision.Dec 22 2014, 8:13 PM
bapt edited edge metadata.
This revision is now accepted and ready to land.Dec 22 2014, 8:13 PM
dumbbell closed this revision.Dec 22 2014, 11:04 PM
dumbbell updated this revision to Diff 2823.

Closed by commit rP375286 (authored by @dumbbell).

Revision Contents
Changeset List

PathSize
Mk/
8 lines
8 lines
games/
sea-defender/
4 lines
files/
patch-snoutlib_gldefs.h
extra-snoutlib_gldefs.h
multimedia/
libva-intel-driver/
10 lines
textproc/
ibus/
5 lines
files/
x11-servers/
xephyr/
6 lines
x11-toolkits/
py-kivy/
6 lines
x11/
kde4-workspace/
4 lines
xorg-minimal/
2 lines

Diff 2819

View Options

Mk/bsd.port.mk

Loading...
View Options

Mk/bsd.sanity.mk

Loading...
View Options

games/sea-defender/Makefile

Loading...
View Options

games/sea-defender/files/extra-snoutlib_gldefs.h

Loading...
View Options

games/sea-defender/files/patch-snoutlib_gldefs.h

Loading...
View Options

multimedia/libva-intel-driver/Makefile

Loading...
View Options

textproc/ibus/Makefile

Loading...
View Options

textproc/ibus/files/extra-xigrabkeycode

Loading...
View Options

x11-servers/xephyr/Makefile

Loading...
View Options

x11-toolkits/py-kivy/Makefile

Loading...
View Options

x11/kde4-workspace/Makefile

Loading...
View Options

x11/xorg-minimal/Makefile

Loading...