Page MenuHomeFreeBSD

Final removal of WITH_NEW_XORG
ClosedPublic

Authored by dumbbell on Dec 22 2014, 9:21 AM.

Details

Summary

The knob was turned on by default more than two months ago. Since then, it was removed from several places. Now that xserver 1.14 is in the tree, this is the final removal.

While here, add WITH_NEW_XORG and WITH_KMS to bsd.sanity.mk to make people remove them from their /etc/make.conf.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

dumbbell updated this revision to Diff 2809.Dec 22 2014, 9:21 AM
dumbbell retitled this revision from to Final removal of WITH_NEW_XORG.
dumbbell updated this object.
dumbbell edited the test plan for this revision. (Show Details)
dumbbell added a reviewer: kwm.
bapt requested changes to this revision.Dec 22 2014, 9:46 AM
bapt added a reviewer: bapt.
This revision now requires changes to proceed.Dec 22 2014, 9:46 AM
kwm requested changes to this revision.Dec 22 2014, 10:30 AM
kwm edited edge metadata.
kwm added inline comments.
x11-servers/xephyr/Makefile
27 ↗(On Diff #2809)

these lines that where between the .else .endif block needs to be removed too.

kwm added a comment.Dec 22 2014, 10:31 AM

Should there be a ports/CHANGES entry because the switches went away?

bapt added a comment.Dec 22 2014, 10:35 AM

I don't think a changes is needed

dumbbell updated this revision to Diff 2819.Dec 22 2014, 5:17 PM
dumbbell edited edge metadata.

Cleanup x11-servers/xephyr/Makefile: only keep the correct Xephyr.1 man page.

In D1351#9, @kwm wrote:

Should there be a ports/CHANGES entry because the switches went away?

I'm not sure it's necessary, the knob is already ineffective/broken.

antoine accepted this revision.Dec 22 2014, 5:22 PM
antoine added a reviewer: antoine.
antoine added a subscriber: antoine.

Looks good to me

kwm accepted this revision.Dec 22 2014, 8:11 PM
kwm edited edge metadata.
bapt accepted this revision.Dec 22 2014, 8:13 PM
bapt edited edge metadata.
This revision is now accepted and ready to land.Dec 22 2014, 8:13 PM
dumbbell closed this revision.Dec 22 2014, 11:04 PM
dumbbell updated this revision to Diff 2823.

Closed by commit rP375286 (authored by @dumbbell).