Page MenuHomeFreeBSD
Differential D10566

enable cloud-init on FreeBSD for Azure
ClosedPublic
Actions

Authored by honzhan_microsoft.com on May 2 2017, 6:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 11:25 AM
Unknown Object (File)
Sat, Apr 13, 4:35 PM
Unknown Object (File)
Fri, Apr 12, 1:24 PM
Unknown Object (File)
Fri, Apr 12, 9:39 AM
Unknown Object (File)
Thu, Mar 28, 5:25 PM
Unknown Object (File)
Mon, Mar 25, 8:20 PM
Unknown Object (File)
Feb 11 2024, 2:16 PM
Unknown Object (File)
Feb 10 2024, 6:36 PM
View All 66 Files
Subscribers
None

Details

Reviewers
decui_microsoft.com
sepherosa_gmail.com
bapt
gjb
Commits
rP441117: Add a cloud init package for FreeBSD on Azure
Summary

cloud-init official version does not support FreeBSD on Azure, the merge request (https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/314895) is still pending for review.
In order not to block the usage on Azure, this ports target to patch on cloud-init 0.7.9 to make it work for FreeBSD 10.3/11 on Azure.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

honzhan_microsoft.com created this revision.May 2 2017, 6:33 AM
honzhan_microsoft.com edited the summary of this revision. (Show Details)May 2 2017, 6:39 AM
honzhan_microsoft.com added reviewers: decui_microsoft.com, sepherosa_gmail.com, bapt, gjb.
honzhan_microsoft.com set the repository for this revision to rP FreeBSD ports repository.
honzhan_microsoft.com updated this revision to Diff 27955.May 3 2017, 1:17 AM

add the missing build for cloud-init-azure

bapt edited edge metadata.May 3 2017, 8:59 AM

I can't see the rc script is it installed by setup.py?
I don't think the pkg-message is needed, it is just the usual way to activate a service

net/cloud-init-azure/Makefile
18

Why is it depending on sudo? I bet cloudinit is run as root isn't it?

47

usually this is a ; not &&

bapt accepted this revision.May 3 2017, 9:00 AM
This revision is now accepted and ready to land.May 3 2017, 9:00 AM
bapt requested changes to this revision.May 6 2017, 12:27 PM

So after looking at the content of the package:
it installs plenty of rc.d/*.orig files that should be removed

The cloudinit_override function is all wrong and should just be removed

All configuration files in /etc are wrong they should be in /usr/local/etc

The NetworkManager hook should just not be installed we do not support networkmanager on freebsd

The libudev rules has no sense on freebsd

/etc/dhcp/dhclient-exit-hooks.d/hook-dhclient is also not valid on freebsd

This revision now requires changes to proceed.May 6 2017, 12:27 PM
honzhan_microsoft.com updated this revision to Diff 28137.May 8 2017, 5:43 AM
honzhan_microsoft.com edited edge metadata.
honzhan_microsoft.com added a comment.May 8 2017, 5:54 AM
In D10566#220480, @bapt wrote:

So after looking at the content of the package:
it installs plenty of rc.d/*.orig files that should be removed

The cloudinit_override function is all wrong and should just be removed

The NetworkManager hook should just not be installed we do not support networkmanager on freebsd

The libudev rules has no sense on freebsd

/etc/dhcp/dhclient-exit-hooks.d/hook-dhclient is also not valid on freebsd

All above have been revised.

All configuration files in /etc are wrong they should be in /usr/local/etc

cloud-init default finds the configuration file from '/etc/cloud', and it is hard coded in settings.py. It is not easy to change this in a short term. Shall we leave it there now?

net/cloud-init-azure/Makefile
18

Yes, I will remove this dependence.

honzhan_microsoft.com updated this revision to Diff 28138.May 8 2017, 5:56 AM
Closed by commit rP441117: Add a cloud init package for FreeBSD on Azure (authored by bapt). · Explain WhyMay 17 2017, 8:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
net/
1 line
cloud-init-azure/
50 lines
2 lines
files/
1214 lines
3 lines
7 lines

Diff 28137

View Options

net/Makefile

Loading...
View Options

net/cloud-init-azure/Makefile

Loading...
View Options

net/cloud-init-azure/distinfo

Loading...
View Options

net/cloud-init-azure/files/patch-frbsd-azure.txt

Loading...
View Options

net/cloud-init-azure/pkg-descr

Loading...
View Options

net/cloud-init-azure/pkg-message

Loading...