Paths

Table of Contentst

Differential D10587

Various Coverity fixes in ifconfig(8)
ClosedPublic
Actions

Authored by asomers on May 3 2017, 4:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 20, 8:21 PM

	Unknown Object (File)
	Mon, May 20, 8:08 PM

	Unknown Object (File)
	Mon, May 20, 8:00 PM

	Unknown Object (File)
	Mon, May 20, 7:59 PM

	Unknown Object (File)
	Mon, May 20, 7:19 PM

	Unknown Object (File)
	Mon, May 13, 9:27 AM

	Unknown Object (File)
	Mon, May 13, 1:55 AM

	Unknown Object (File)
	Sun, May 12, 10:25 PM

View All 29 Files

Subscribers

Details

Reviewers

Commits

rS319265: MFC r317755, r317758
rS318813: MFC r317755, r317758
rS317755: Various Coverity fixes in ifconfig(8)

Summary

Various Coverity fixes in ifconfig(8)

Exit early if kldload(2) fails (1011259). This is the only change that affects ifconfig's behavior.
Close memory and resource leaks (1305624, 1305205, 1007100)
Mark usage() as _Noreturn (1305806, 1305750)
Fix some dereference after null checks (1011474, 270774)

CID: 1305624, 1305205, 1007100, 1305806, 1305750, 1011474, 270774,
CID: 1011259

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.May 3 2017, 4:27 PM

Harbormaster completed remote builds in B9051: Diff 27981.May 3 2017, 4:27 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 3 2017, 4:27 PM

cem added inline comments.May 3 2017, 4:49 PM

sbin/ifconfig/af_inet6.c
358 ↗	(On Diff #27981)	res is uninitialized in some cases.
sbin/ifconfig/ifconfig.c
109 ↗	(On Diff #27981)	I believe the preferred style for declarations is to put attributes after the declaration. Like: `static void usage(void) _Noreturn;`

Respond to cem's comments

Harbormaster completed remote builds in B9051: Diff 27981.May 3 2017, 5:07 PM

LGTM other than the whitespace nit below.

sbin/ifconfig/ifconfig.c
109 ↗	(On Diff #27984)	Well, keep the preexisting space/tab style :-).

Closed by commit rS317755: Various Coverity fixes in ifconfig(8) (authored by asomers). · Explain WhyMay 3 2017, 5:21 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B9053: Diff 27984!May 3 2017, 5:48 PM

Revision Contents
Changeset List

Path

Size

head/

sbin/

ifconfig/

12 lines

1 line

43 lines

13 lines

1 line

Diff 27985

head/sbin/ifconfig/af_inet6.c

Loading...

head/sbin/ifconfig/ifclone.c

Loading...

head/sbin/ifconfig/ifconfig.c

Loading...

head/sbin/ifconfig/iflagg.c

Loading...

head/sbin/ifconfig/ifpfsync.c

Loading...