Page MenuHomeFreeBSD
Differential D10587

Various Coverity fixes in ifconfig(8)
ClosedPublic
Actions

Authored by asomers on May 3 2017, 4:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 11, 4:07 PM
Unknown Object (File)
Fri, Sep 11, 4:14 AM
Unknown Object (File)
Thu, Sep 10, 11:22 PM
Unknown Object (File)
Thu, Sep 10, 1:10 PM
Unknown Object (File)
Thu, Sep 10, 8:53 AM
Unknown Object (File)
Thu, Sep 10, 2:55 AM
Unknown Object (File)
Wed, Sep 9, 8:40 AM
Unknown Object (File)
Sun, Sep 6, 11:43 PM
View All Files
Subscribers
imp

Details

Reviewers
cem
Commits
rS319265: MFC r317755, r317758
rS318813: MFC r317755, r317758
rS317755: Various Coverity fixes in ifconfig(8)
Summary

Various Coverity fixes in ifconfig(8)

  • Exit early if kldload(2) fails (1011259). This is the only change that affects ifconfig's behavior.
  • Close memory and resource leaks (1305624, 1305205, 1007100)
  • Mark usage() as _Noreturn (1305806, 1305750)
  • Fix some dereference after null checks (1011474, 270774)

CID: 1305624, 1305205, 1007100, 1305806, 1305750, 1011474, 270774,
CID: 1011259

Diff Detail

Event Timeline

asomers created this revision.May 3 2017, 4:27 PM
Harbormaster completed remote builds in B9051: Diff 27981.May 3 2017, 4:27 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 3 2017, 4:27 PM
cem added inline comments.May 3 2017, 4:49 PM
sbin/ifconfig/af_inet6.c
360

res is uninitialized in some cases.

sbin/ifconfig/ifconfig.c
109

I believe the preferred style for declarations is to put attributes after the declaration. Like:

static void usage(void) _Noreturn;

asomers updated this revision to Diff 27984.May 3 2017, 5:01 PM

Respond to cem's comments

Harbormaster completed remote builds in B9051: Diff 27981.May 3 2017, 5:07 PM
cem edited edge metadata.May 3 2017, 5:17 PM

LGTM other than the whitespace nit below.

sbin/ifconfig/ifconfig.c
109

Well, keep the preexisting space/tab style :-).

Closed by commit rS317755: Various Coverity fixes in ifconfig(8) (authored by asomers). · Explain WhyMay 3 2017, 5:21 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B9053: Diff 27984!May 3 2017, 5:48 PM

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
12 lines
1 line
43 lines
13 lines
1 line

Diff 27984

View Options

sbin/ifconfig/af_inet6.c

Loading...
View Options

sbin/ifconfig/ifclone.c

Loading...
View Options

sbin/ifconfig/ifconfig.c

Loading...
View Options

sbin/ifconfig/iflagg.c

Loading...
View Options

sbin/ifconfig/ifpfsync.c

Loading...