Make semaphore names list mutex non-recursive.
ClosedPublic
Actions

Authored by kib on Apr 30 2017, 10:57 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Sep 6, 5:37 PM

	Unknown Object (File)
	Sun, Sep 6, 2:29 PM

	Unknown Object (File)
	Sun, Sep 6, 4:01 AM

	Unknown Object (File)
	Sun, Sep 6, 3:20 AM

	Unknown Object (File)
	Sat, Sep 5, 7:04 PM

	Unknown Object (File)
	Sat, Sep 5, 6:13 PM

	Unknown Object (File)
	Thu, Sep 3, 3:21 AM

	Unknown Object (File)
	Thu, Sep 3, 12:13 AM

View All Files

Subscribers

imp

Details

Reviewers

jilles
vangyzen

Commits

rS317611: Make semaphore names list mutex non-recursive.

Summary

I do not see how recursion can be realized in the current code.

The mutex is used un sem_open() and sem_close(), which cannot recurse. The atfork handlers cannot collide with the open and close code.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Apr 30 2017, 10:57 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 30 2017, 10:57 AM

Harbormaster failed remote builds in B8986: Diff 27857!Apr 30 2017, 11:01 AM

vangyzen accepted this revision.Apr 30 2017, 12:47 PM

This revision is now accepted and ready to land.Apr 30 2017, 12:47 PM

Closed by commit rS317611: Make semaphore names list mutex non-recursive. (authored by kib). · Explain WhyApr 30 2017, 7:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

gen/

sem_new.c

6 lines

Diff 27872

View Options

head/lib/libc/gen/sem_new.c

Make semaphore names list mutex non-recursive.ClosedPublicActions