Make semaphore names list mutex non-recursive.
ClosedPublic
Actions

Authored by kib on Apr 30 2017, 10:57 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 22, 3:14 AM

	Unknown Object (File)
	Fri, May 22, 3:13 AM

	Unknown Object (File)
	Thu, May 21, 3:34 PM

	Unknown Object (File)
	Mon, May 18, 10:36 AM

	Unknown Object (File)
	Sun, May 17, 5:07 PM

	Unknown Object (File)
	Thu, May 7, 8:44 PM

	Unknown Object (File)
	Thu, May 7, 3:30 PM

	Unknown Object (File)
	Mon, May 4, 4:40 PM

View All 83 Files

Subscribers

imp

Details

Reviewers

jilles
vangyzen

Commits

rS317611: Make semaphore names list mutex non-recursive.

Summary

I do not see how recursion can be realized in the current code.

The mutex is used un sem_open() and sem_close(), which cannot recurse. The atfork handlers cannot collide with the open and close code.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 8986
Build 9382: CI src build	Jenkins

Event Timeline

kib created this revision.Apr 30 2017, 10:57 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 30 2017, 10:57 AM

Harbormaster failed remote builds in B8986: Diff 27857!Apr 30 2017, 11:01 AM

vangyzen accepted this revision.Apr 30 2017, 12:47 PM

This revision is now accepted and ready to land.Apr 30 2017, 12:47 PM

Closed by commit rS317611: Make semaphore names list mutex non-recursive. (authored by kib). · Explain WhyApr 30 2017, 7:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

sem_new.c

6 lines

Diff 27857

View Options

Make semaphore names list mutex non-recursive.ClosedPublicActions