Page MenuHomeFreeBSD

Prevent SEGV on corrupted msdos directories
AbandonedPublic

Authored by sevan on Apr 28 2017, 6:01 PM.
Tags
None
Referenced Files
F106270724: D10539.id27836.diff
Sat, Dec 28, 7:23 AM
Unknown Object (File)
Fri, Dec 20, 9:52 AM
Unknown Object (File)
Thu, Dec 12, 7:00 PM
Unknown Object (File)
Sep 27 2024, 5:47 PM
Unknown Object (File)
Sep 27 2024, 12:26 PM
Unknown Object (File)
Sep 8 2024, 12:26 PM
Unknown Object (File)
Sep 4 2024, 2:30 PM
Unknown Object (File)
Aug 15 2024, 7:04 PM
Subscribers

Details

Reviewers
bcr
emaste
Summary

By Veo Zhang via NetBSD
Tested it builds as an individual component (not as part of build world) but
haven't performed any tests on a file system.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8974
Build 9368: arc lint + arc unit

Event Timeline

You need to find someone more knowledgeable in that area (i.e. src-committer) to look over that change. Maybe someone who recently made some change to the same code area: https://svnweb.freebsd.org/base/head/sbin/fsck_msdosfs/

It is not incorrect but it looks somewhat weird: Perhaps it's just an off-by-one and changing k >=0 to k > 0 in line 620 solves it more cleanly.

I'll think of it for a while :).