Differential D10458

usr.sbin/sesutil: locate all off does not deactivate empty slots
ClosedPublic
Actions

Authored by allanjude on Apr 22 2017, 4:59 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 5, 6:40 PM

	Unknown Object (File)
	Sat, Sep 5, 6:39 PM

	Unknown Object (File)
	Sat, Sep 5, 9:38 AM

	Unknown Object (File)
	Sat, Sep 5, 12:43 AM

	Unknown Object (File)
	Fri, Sep 4, 9:58 PM

	Unknown Object (File)
	Thu, Sep 3, 4:18 AM

	Unknown Object (File)
	Thu, Sep 3, 3:02 AM

	Unknown Object (File)
	Wed, Sep 2, 11:32 PM

Subscribers

Details

Reviewers

bapt
asomers

Commits

rS319610: usr.sbin/sesutil: 'locate all off' does not deactivate empty slots

Summary

Reported By: asomers
PR: 217409

"sesutil locate all off" will skip empty slots. This is a problem, because for example if you use "sesutil locate da5 on" to locate a bad drive and then remove it, you can't turn the beacon off without using a sesid. The fault command is probably affected too, but I didn't test it.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8846
Build 9223: CI src build	Jenkins
Build 9222: arc lint + arc unit

Event Timeline

allanjude created this revision.Apr 22 2017, 4:59 AM

Harbormaster completed remote builds in B8846: Diff 27629.Apr 22 2017, 4:59 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 22 2017, 4:59 AM

Harbormaster completed remote builds in B8846: Diff 27629.Apr 22 2017, 5:44 AM

Works for me.

This revision is now accepted and ready to land.May 4 2017, 8:09 PM

bapt accepted this revision.May 4 2017, 10:09 PM

Closed by commit rS319610: usr.sbin/sesutil: 'locate all off' does not deactivate empty slots (authored by allanjude). · Explain WhyJun 6 2017, 2:03 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.sbin/

sesutil/

9 lines

Diff 27629

usr.sbin/sesutil/sesutil.c

Loading...