Page MenuHomeFreeBSD
Differential D10421

loader: uboot disk ioctl should call disk_ioctl
ClosedPublic
Actions

Authored by tsoome on Apr 18 2017, 4:03 PM.
Tags
None
Referenced Files
F171209696: D10421.diff
Wed, Sep 9, 1:20 PM
Unknown Object (File)
Sun, Sep 6, 5:08 AM
Unknown Object (File)
Sat, Sep 5, 9:58 PM
Unknown Object (File)
Sat, Aug 22, 1:57 AM
Unknown Object (File)
Sat, Aug 22, 1:57 AM
Unknown Object (File)
Tue, Aug 18, 3:25 PM
Unknown Object (File)
Mon, Aug 17, 8:44 PM
Unknown Object (File)
Mon, Aug 17, 4:35 AM
View All Files
Subscribers
• ian
imp

Details

Reviewers
emaste
• ian
Commits
rS317099: loader: uboot disk ioctl should call disk_ioctl
Summary

As the uboot disk interface is using common/disk.c API, we also
should use disk_ioctl() call, this will give us chance to read partition
sizes and have feature parity with UEFI and BIOS implementations.

Diff Detail

Event Timeline

tsoome created this revision.Apr 18 2017, 4:03 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 18 2017, 4:03 PM
Harbormaster completed remote builds in B8779: Diff 27522.Apr 18 2017, 4:38 PM
• ian accepted this revision.Apr 18 2017, 7:30 PM
• ian added a subscriber: • ian.

Looks fine to me.

Tested on beaglebone black, this fixes the "disk0: real size != size" error I was seeing after r317097

This revision is now accepted and ready to land.Apr 18 2017, 7:30 PM
Closed by commit rS317099: loader: uboot disk ioctl should call disk_ioctl (authored by tsoome). · Explain WhyApr 18 2017, 7:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
boot/
uboot/
lib/
5 lines

Diff 27522

View Options

sys/boot/uboot/lib/disk.c

Loading...