The maximum scale is 6 (K, M, G, T, P, E) (B is 0).
ClosedPublic
Actions

Authored by brooks on Apr 12 2017, 10:33 PM.

Tags

None

Referenced Files

	F109244985: D10376.diff
	Sun, Feb 2, 1:26 PM

	Unknown Object (File)
	Thu, Jan 23, 5:55 AM

	Unknown Object (File)
	Dec 16 2024, 11:09 PM

	Unknown Object (File)
	Oct 21 2024, 11:14 AM

	Unknown Object (File)
	Oct 21 2024, 11:14 AM

	Unknown Object (File)
	Oct 21 2024, 11:14 AM

	Unknown Object (File)
	Oct 21 2024, 10:41 AM

	Unknown Object (File)
	Sep 21 2024, 5:25 AM

View All 51 Files

Subscribers

None

Details

Reviewers

jmg
jhb
emaste

Commits

rS316766: Correct an out of bounds read with HN_AUTOSCALE and very large numbers.

Summary

Overly large explict scales were checked correctly, but for sufficently
large numbers HN_AUTOSCALE would get to 7 resulting in an out of bounds
read.

Found with humanize_number_test and CHERI bounds checking.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Apr 12 2017, 10:33 PM

Harbormaster completed remote builds in B8704: Diff 27389.Apr 12 2017, 10:33 PM

emaste accepted this revision.Apr 12 2017, 11:04 PM

This revision is now accepted and ready to land.Apr 12 2017, 11:04 PM

Closed by commit rS316766: Correct an out of bounds read with HN_AUTOSCALE and very large numbers. (authored by brooks). · Explain WhyApr 13 2017, 3:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libutil/

humanize_number.c

4 lines

Diff 27412

View Options

head/lib/libutil/humanize_number.c

The maximum scale is 6 (K, M, G, T, P, E) (B is 0).ClosedPublicActions