- Update to 2.3.0
- Switch to kf5 based version.
Details
Details
- Reviewers
rakuco mat adridg - Group Reviewers
kde - Commits
- rP438134: MFH: r437749
rP437749: Update math/labplot to 2.3.0 and give maintainership to kde@
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 8448 Build 8745: arc lint + arc unit
Event Timeline
| math/labplot/pkg-plist | ||
|---|---|---|
| 146 | I think you can just do DATADIR= ${PREFIX}/share/labplot2 in the Makefile. | |
| math/labplot/Makefile | ||
|---|---|---|
| 6 | Is this really necessary? To me this is just an update to the port that happens to make it depend on Qt5/KF5. | |
| 13 | The license (at least in the handful of files I checked) seems to be GPLv2+. | |
| 16 | v2.3.0 seems to always look for some optional dependencies and enable them if they happen to be found (there's been a commit in git after that which adds CMake options for those dependencies). fftw3, hdf5, netcdf and cantor all seem to fall in this category. You need to either depend on them unconditionally (not sure if any of those is too big a dependency) or make sure they are not automagically enabled if found. | |
| 26 | I wonder if these two are still necessary. | |
Comment Actions
Backport commit to make hdf5, fftw3 and netcdf optional.
Adress other issues mentioned by rakuco.
| math/labplot/Makefile | ||
|---|---|---|
| 6 | This is DISTVERSIONPREFIX, it has no influenc on the pkgname (they provide two tarballs, one is called labplot-2.3.0-kf5.tar.xz, the other labplot-2.3.0.tar.xz). | |
| 16 | I'll try to optionify it. Cantor won't be picked up anyway, as it is still the outdated version. | |
| 26 | You're right. According to stage-qa they are not needed. | |