Page MenuHomeFreeBSD
Differential D10191

Update graphics/showimage to 0.10 and take maintainership
ClosedPublic
Actions

Authored by tcberner on Mar 29 2017, 10:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 29, 1:26 PM
Unknown Object (File)
Fri, Nov 29, 8:50 AM
Unknown Object (File)
Thu, Nov 28, 2:47 PM
Unknown Object (File)
Mon, Nov 25, 7:35 AM
Unknown Object (File)
Sat, Nov 23, 12:37 PM
Unknown Object (File)
Sat, Nov 23, 3:32 AM
Unknown Object (File)
Fri, Nov 22, 4:20 PM
Unknown Object (File)
Fri, Nov 22, 2:51 PM
View All Files
Subscribers
None

Details

Reviewers
rakuco
mat
adridg
Group Reviewers
kde
Commits
rP437347: Update graphics/showimage to 0.10 and take maintainership.
Summary
  • Update to 0.10 (kf5)
  • Rename the installed binary from showimage to showimage-kde (previously it was showimage-kde4, but that does not make much sense anymore)
  • Take maintainership.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 8384
Build 8660: arc lint + arc unit

Event Timeline

tcberner created this revision.Mar 29 2017, 10:25 PM
Harbormaster completed remote builds in B8378: Diff 26795.Mar 29 2017, 10:26 PM
mat added inline comments.Mar 30 2017, 6:52 AM
graphics/showimage/files/patch-showimage.desktop
1–3

I don't see the point in this comment.
I get the idea, but this has the same problem as the trend of writing very bad commit messages explaining almost line by line what is being done in the commit.
The what is self-explanatory, yeah, the executable is renamed, I can see that.
A better comment would be "don't conflict with blah", and stop there, or, as it was already explained in another patch, just "see patch-foo".

tcberner updated this revision to Diff 26808.Mar 30 2017, 6:55 AM

Get rid of obvious comment.

Harbormaster completed remote builds in B8384: Diff 26808.Mar 30 2017, 6:55 AM
mat added inline comments.Mar 30 2017, 7:23 AM
graphics/showimage/Makefile
23

I don't really see the point in setting the id outside of the URL, it is not used anywhere else.

I also grep'ed the ports tree, and there does not seem to be any other use of that variable.

tcberner updated this revision to Diff 26809.Mar 30 2017, 7:35 AM

Get rid of ID-variable.

Harbormaster completed remote builds in B8385: Diff 26809.Mar 30 2017, 7:35 AM
mat accepted this revision.Mar 30 2017, 9:50 PM

Looks good :-)

This revision is now accepted and ready to land.Mar 30 2017, 9:50 PM
rakuco accepted this revision.Mar 31 2017, 10:07 AM

lgtm

Closed by commit rP437347: Update graphics/showimage to 0.10 and take maintainership. (authored by tcberner). · Explain WhyMar 31 2017, 10:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
graphics/
showimage/
24 lines
5 lines
files/
51 lines
9 lines
7 lines

Diff 26808

View Options

graphics/showimage/Makefile

Loading...
View Options

graphics/showimage/distinfo

Loading...
View Options

graphics/showimage/files/patch-CMakeLists.txt

Loading...
View Options

graphics/showimage/files/patch-showimage.desktop

Loading...
View Options

graphics/showimage/pkg-plist

Loading...