Page MenuHomeFreeBSD

Exclude assembly files from LLVM IR Builds
AbandonedPublic

Authored by bkidney_briankidney.ca on Mar 2 2017, 2:05 AM.
Tags
None
Referenced Files
F127006122: D9853.id26479.diff
Tue, Aug 26, 1:06 PM
Unknown Object (File)
Sun, Aug 24, 10:45 PM
Unknown Object (File)
Fri, Aug 22, 3:58 PM
Unknown Object (File)
Wed, Aug 20, 7:54 PM
Unknown Object (File)
Tue, Aug 19, 6:29 PM
Unknown Object (File)
Mon, Aug 18, 2:52 PM
Unknown Object (File)
Fri, Aug 15, 5:46 PM
Unknown Object (File)
Sat, Aug 9, 11:37 AM
Subscribers

Details

Reviewers
jonathan
bdrewery
Summary

Excludes machine dependant code (*.S) that were causing builds to fail.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8174
Build 8402: arc lint + arc unit

Event Timeline

bkidney_briankidney.ca retitled this revision from to Exclude assembly files from LLVM IR Builds.
bkidney_briankidney.ca updated this object.
bkidney_briankidney.ca edited the test plan for this revision. (Show Details)
share/mk/bsd.lib.mk
203

How does this interact with STATICOBJS? I think that only gets used in libpam, but it would be worth checking whether we need to do the same thing there.

  • Adds filtering to STATICOBJS for BCOJBS and LLOBJS list creation.

Roling back last commit.

As I hit enter I realized that though it is safe to filer the STATICOBJS list it doesn't make sense. STATICOBJS list only include .o files.

share/mk/bsd.lib.mk
203

STATICOBJS is initialized in the Makefile for individual builds (libc, libc++, libpam, and libgcc). In this build file it is only a list of ".o" files and we do not know there origin to determine if they should be filtered.