Page MenuHomeFreeBSD
Differential D9853

Exclude assembly files from LLVM IR Builds
AbandonedPublic
Actions

Authored by bkidney_briankidney.ca on Mar 2 2017, 2:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 21, 8:16 PM
Unknown Object (File)
Mon, Jul 14, 10:10 PM
Unknown Object (File)
Mon, Jul 14, 9:30 PM
Unknown Object (File)
Fri, Jul 11, 10:23 AM
Unknown Object (File)
Thu, Jul 10, 3:40 PM
Unknown Object (File)
Wed, Jul 9, 2:54 PM
Unknown Object (File)
Wed, Jul 9, 10:53 AM
Unknown Object (File)
Mon, Jul 7, 1:43 PM
View All Files
Subscribers
emaste

Details

Reviewers
jonathan
bdrewery
Summary

Excludes machine dependant code (*.S) that were causing builds to fail.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8174
Build 8402: arc lint + arc unit

Event Timeline

bkidney_briankidney.ca updated this revision to Diff 25856.Mar 2 2017, 2:05 AM
bkidney_briankidney.ca retitled this revision from to Exclude assembly files from LLVM IR Builds.
bkidney_briankidney.ca updated this object.
bkidney_briankidney.ca edited the test plan for this revision. (Show Details)
bkidney_briankidney.ca added reviewers: jonathan, bdrewery.
Herald added a subscriber: emaste. · View Herald TranscriptMar 2 2017, 2:05 AM
jonathan added inline comments.Mar 11 2017, 3:12 AM
share/mk/bsd.lib.mk
203

How does this interact with STATICOBJS? I think that only gets used in libpam, but it would be worth checking whether we need to do the same thing there.

bkidney_briankidney.ca updated this revision to Diff 26479.Mar 21 2017, 1:03 AM
  • Adds filtering to STATICOBJS for BCOJBS and LLOBJS list creation.
Harbormaster completed remote builds in B8174: Diff 26479.Mar 21 2017, 1:03 AM
bkidney_briankidney.ca updated this revision to Diff 26480.Mar 21 2017, 1:09 AM

Roling back last commit.

As I hit enter I realized that though it is safe to filer the STATICOBJS list it doesn't make sense. STATICOBJS list only include .o files.

Harbormaster completed remote builds in B8175: Diff 26480.Mar 21 2017, 1:09 AM
bkidney_briankidney.ca added inline comments.Mar 21 2017, 1:14 AM
share/mk/bsd.lib.mk
203

STATICOBJS is initialized in the Makefile for individual builds (libc, libc++, libpam, and libgcc). In this build file it is only a list of ".o" files and we do not know there origin to determine if they should be filtered.

jonathan added a comment.Oct 18 2017, 10:07 PM

I think this may now be redundant in light of https://reviews.freebsd.org/D12701?

bkidney_briankidney.ca abandoned this revision.Oct 18 2017, 10:28 PM

Made redundant by https://reviews.freebsd.org/D12701.

Revision Contents
Changeset List

PathSize
share/
mk/
4 lines

Diff 26479

View Options

share/mk/bsd.lib.mk

Loading...