Page MenuHomeFreeBSD
Differential D10040

pf: Fix memory leak on vnet shutdown or unload
ClosedPublic
Actions

Authored by kp on Mar 17 2017, 5:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 1, 8:46 AM
Unknown Object (File)
Tue, Sep 30, 8:21 AM
Unknown Object (File)
Tue, Sep 30, 2:03 AM
Unknown Object (File)
Mon, Sep 29, 10:53 PM
Unknown Object (File)
Sat, Sep 27, 3:07 PM
Unknown Object (File)
Sat, Sep 27, 2:32 PM
Unknown Object (File)
Thu, Sep 18, 2:32 AM
Unknown Object (File)
Sat, Sep 6, 7:57 PM
View All 90 Files
Subscribers
bz

Details

Reviewers
eri
bz
Group Reviewers
network
Commits
rS315469: pf: Fix memory leak on vnet shutdown or unload
Summary

Rules are unlinked in shutdown_pf(), so we must call
pf_unload_vnet_purge(), which frees unlinked rules, after that, not
before.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Mar 17 2017, 5:37 AM
kp added reviewers: network, eri.Mar 17 2017, 5:54 AM
kp set the repository for this revision to rS FreeBSD src repository - subversion.
eri accepted this revision.Mar 17 2017, 10:02 PM

Good catch.

This revision is now accepted and ready to land.Mar 17 2017, 10:02 PM
bz accepted this revision.Mar 17 2017, 10:19 PM
bz added a subscriber: bz.

It is unclear to me why I had chosen the different order in r302156 but on a quick glance this looks OK.

Closed by commit rS315469: pf: Fix memory leak on vnet shutdown or unload (authored by kp). · Explain WhyMar 18 2017, 1:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
netpfil/
pf/
4 lines

Diff 26379

View Options

head/sys/netpfil/pf/pf_ioctl.c

Loading...