Fix a memory leak in ccdconfig
ClosedPublic
Actions

Authored by trix_juniper.net on Mar 14 2017, 3:11 AM.

Details

Reviewers

imp
uqs

Summary

ccdconfig.c do_all
Fix the memory leak of realloc failure by using realocf instead.

Test Plan

Use clang's static analyzer, scan-build, to find the problem and later to show resolution.

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Hmmm... In this case it wouldn't be a lot more effort to just use realloc() and free(). That said, this tool is specific to FreeBSD anyway.

This revision is now accepted and ready to land.Mar 14 2017, 11:43 AM

imp accepted this revision.Mar 14 2017, 4:56 PM

imp added inline comments.

sbin/ccdconfig/ccdconfig.c
315	While this is a simple fix, what's the point? We return from this function and exit right away... No objection,

I am pedantically scrubbing all of the memory leaks and this is a leak.
Problems must fixed so they don¹t turn up in future scans.

uqs resigned from this revision.Aug 21 2020, 1:57 PM

Actually, this is wrong. reallocf will return argv when we can't allocate new memory. So we'd never hit the warn and return.

Path

Size

sbin/

ccdconfig/

2 lines