Fix a memory leak in ccdconfig

[trix_juniper.net]

Summary

ccdconfig.c do_all
Fix the memory leak of realloc failure by using realocf instead.

Test Plan

Use clang's static analyzer, scan-build, to find the problem and later to show resolution.

[ed]

Hmmm... In this case it wouldn't be a lot more effort to just use realloc() and free(). That said, this tool is specific to FreeBSD anyway.

[imp]

sbin/ccdconfig/ccdconfig.c

315

While this is a simple fix, what's the point?
We return from this function and exit right away...
No objection,

[trix_juniper.net]

I am pedantically scrubbing all of the memory leaks and this is a leak.
Problems must fixed so they don¹t turn up in future scans.

[imp]

Actually, this is wrong. reallocf will return argv when we can't allocate new memory. So we'd never hit the warn and return.