Paths

Table of Contentst

Fix a memory leak in ccdconfig
AcceptedPublic
Actions

Authored by trix_juniper.net on Mar 14 2017, 3:11 AM.

Tags

None

Referenced Files

	F81634906: D9996.diff
	Fri, Apr 19, 7:16 AM

	Unknown Object (File)
	Thu, Apr 18, 10:02 AM

	Unknown Object (File)
	Tue, Apr 16, 7:22 PM

	Unknown Object (File)
	Tue, Apr 2, 9:58 PM

	Unknown Object (File)
	Jan 23 2024, 8:36 PM

	Unknown Object (File)
	Jan 17 2024, 1:19 PM

	Unknown Object (File)
	Dec 28 2023, 5:56 AM

	Unknown Object (File)
	Nov 3 2023, 11:01 PM

View All 19 Files

Subscribers

imp

Details

Reviewers

imp
uqs

Summary

ccdconfig.c do_all
Fix the memory leak of realloc failure by using realocf instead.

Test Plan

Use clang's static analyzer, scan-build, to find the problem and later to show resolution.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

trix_juniper.net created this revision.Mar 14 2017, 3:11 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 14 2017, 3:11 AM

Hmmm... In this case it wouldn't be a lot more effort to just use realloc() and free(). That said, this tool is specific to FreeBSD anyway.

This revision is now accepted and ready to land.Mar 14 2017, 11:43 AM

imp accepted this revision.Mar 14 2017, 4:56 PM

imp added inline comments.

sbin/ccdconfig/ccdconfig.c
315	While this is a simple fix, what's the point? We return from this function and exit right away... No objection,

I am pedantically scrubbing all of the memory leaks and this is a leak.
Problems must fixed so they don¹t turn up in future scans.

ed removed a reviewer: ed.Nov 21 2017, 9:43 PM

uqs resigned from this revision.Aug 21 2020, 1:57 PM

Revision Contents
Changeset List

Path

Size

sbin/

ccdconfig/

ccdconfig.c

2 lines

Diff 26241

View Options

sbin/ccdconfig/ccdconfig.c

Fix a memory leak in ccdconfigAcceptedPublicActions