Page MenuHomeFreeBSD
Differential D9982

Fix a memory leak in lpr, alternate checks...
ClosedPublic
Actions

Authored by gad on Mar 12 2017, 9:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 3, 10:43 PM
Unknown Object (File)
Sun, Nov 23, 4:04 AM
Unknown Object (File)
Thu, Nov 20, 8:48 PM
Unknown Object (File)
Thu, Nov 20, 8:47 PM
Unknown Object (File)
Thu, Nov 20, 8:37 PM
Unknown Object (File)
Nov 7 2025, 2:46 AM
Unknown Object (File)
Oct 24 2025, 7:09 PM
Unknown Object (File)
Oct 15 2025, 2:18 AM
View All 60 Files
Subscribers
imp
pfg

Details

Reviewers
ngie
gad
Commits
rS315655: Fixes to chkprintcap:
Summary

This is meant as a follow-up to "D9954: Fix a memory leak in lpr"

... but I suspect that I'm not doing this right!

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 8023
Build 8199: CI src buildJenkins

Event Timeline

gad created this revision.Mar 12 2017, 9:31 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 12 2017, 9:31 PM
gad added reviewers: pfg, ngie.Mar 12 2017, 9:34 PM
Harbormaster failed remote builds in B8023: Diff 26198!Mar 12 2017, 9:35 PM
gad mentioned this in D9954: Fix a memory leak in lpr.Mar 12 2017, 9:36 PM
gad added a reviewer: gad.Mar 12 2017, 10:12 PM
gad edited edge metadata.Mar 12 2017, 10:15 PM

Hmm. Odd that it didn't build. It did compile on my system, although I didn't do much more than compile it.

pfg resigned from this revision.Mar 12 2017, 10:33 PM

Phabricator has been hitting false build positives, don't worry.
I'll stand down as reviewer... I have too much to do on other fronts :(.

ngie edited edge metadata.EditedMar 13 2017, 2:33 AM
ngie added a subscriber: pfg.
In D9982#206141, @pfg wrote:

Phabricator has been hitting false build positives, don't worry.
I'll stand down as reviewer... I have too much to do on other fronts :(.

The issue is that ^/head isn't healthy. rS315112 introduced a geom panic that's triggered by the geli tests.

Harbormaster failed remote builds in B8023: Diff 26198!Mar 17 2017, 7:08 PM
ngie accepted this revision.Mar 17 2017, 7:51 PM
This revision is now accepted and ready to land.Mar 17 2017, 7:51 PM
gad mentioned this in rS315655: Fixes to chkprintcap:.Mar 20 2017, 10:36 PM
gad added a parent revision: D9954: Fix a memory leak in lpr.Mar 20 2017, 11:13 PM
gad added a commit: rS315655: Fixes to chkprintcap:.
gad removed a parent revision: D9954: Fix a memory leak in lpr.Mar 21 2017, 5:49 PM
gad closed this revision.Mar 21 2017, 6:10 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
lpr/
chkprintcap/
12 lines

Diff 26198

View Options

usr.sbin/lpr/chkprintcap/chkprintcap.c

Loading...