Fix a memory leak in libutil
ClosedPublic
Actions

Authored by trix_juniper.net on Mar 2 2017, 3:19 PM.

Details

Reviewers

jhb
stevek

Commits

rS319443: When sysctlbyname fails, free buf before returning.

Summary

kinfo_getvmobject.c kinfo_getvmobject
When sysctlbyname fails, free buf before returning.

Test Plan

Use clang's static analyzer, scan-build, to find the problem and show resolution.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

trix_juniper.net updated this revision to Diff 25890.Mar 2 2017, 3:19 PM

trix_juniper.net retitled this revision from to Fix a memory leak in libutil.

trix_juniper.net updated this object.

trix_juniper.net edited the test plan for this revision. (Show Details)

trix_juniper.net added reviewers: stevek, jhb.

trix_juniper.net set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptMar 2 2017, 3:19 PM

Hmm, I was going to suggest looking in other places in libutil that I copied this from, but it seems other kinfo_getfoo() functions don't use a loop to retry but just add a fudge factor to the size and hope it is enough.

This revision is now accepted and ready to land.Mar 2 2017, 5:13 PM

Closed by commit rS319443: When sysctlbyname fails, free buf before returning. (authored by stevek). · Explain WhyJun 1 2017, 4:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

libutil/

kinfo_getvmobject.c

4 lines

Diff 25890

View Options

lib/libutil/kinfo_getvmobject.c

Fix a memory leak in libutilClosedPublicActions