Page MenuHomeFreeBSD
Differential D9529

Output file name from "preload" type md(4) device
ClosedPublic
Actions

Authored by stevek on Feb 10 2017, 5:22 PM.
Tags
None
Referenced Files
F81672094: D9529.id25102.diff
Fri, Apr 19, 5:56 PM
Unknown Object (File)
Thu, Apr 18, 12:28 PM
Unknown Object (File)
Thu, Mar 28, 8:59 PM
Unknown Object (File)
Mar 12 2024, 3:01 AM
Unknown Object (File)
Mar 12 2024, 3:01 AM
Unknown Object (File)
Mar 12 2024, 3:01 AM
Unknown Object (File)
Mar 12 2024, 2:49 AM
Unknown Object (File)
Feb 15 2024, 3:13 PM
View All 33 Files
Subscribers
imp

Details

Reviewers
brooks
Commits
rS313701: For MD_PRELOAD type md(4) devices, if there is a file name in the preloaded
Summary

For MD_PRELOAD type md(4) devices, if there is a file name in the preloaded
meta-data, copy it into the softc structure.

When returning md(4) device details to the caller, include the file name in
any MD_PRELOAD type devices if it is set (first character is not NUL.)

In mdconfig, for "preload" type md(4) devices, if there is file config
available, print it in the file column of the output.

Test Plan

Built and tested on x86 and ARM by pre-loading ISO images from the loader and
checking mdconfig output. Also created other md types to ensure output from
mdconfig looks correct.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7336
Build 7503: arc lint + arc unit

Event Timeline

stevek updated this revision to Diff 24970.Feb 10 2017, 5:22 PM
stevek retitled this revision from to Output file name from "preload" type md(4) device.
stevek updated this object.
stevek edited the test plan for this revision. (Show Details)
stevek added a reviewer: brooks.
Herald added a subscriber: imp. · View Herald TranscriptFeb 10 2017, 5:22 PM
brooks accepted this revision.Feb 10 2017, 5:34 PM
brooks edited edge metadata.

Looks good to me.

sys/dev/md/md.c
1694

Not new in your code, but this case is awful. It does does a copyout to the buffer and just hopes it's at least PATH_MAX.

This revision is now accepted and ready to land.Feb 10 2017, 5:34 PM
stevek added inline comments.Feb 13 2017, 5:41 PM
sys/dev/md/md.c
1694

yes, the problem is the md_ioctl structure does not have a size for the md_file member and it really should.

Closed by commit rS313701: For MD_PRELOAD type md(4) devices, if there is a file name in the preloaded (authored by stevek). · Explain WhyFeb 13 2017, 5:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sbin/
mdconfig/
3 lines
sys/
dev/
md/
11 lines

Diff 24970

View Options

sbin/mdconfig/mdconfig.c

Loading...
View Options

sys/dev/md/md.c

Loading...