Page MenuHomeFreeBSD
Differential D1184

Misc fixes for auto_master(5)
ClosedPublic
Actions

Authored by trasz on Nov 18 2014, 10:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 5:12 PM
Unknown Object (File)
Tue, Dec 10, 2:29 PM
Unknown Object (File)
Sat, Nov 30, 9:13 AM
Unknown Object (File)
Nov 23 2024, 7:51 AM
Unknown Object (File)
Nov 20 2024, 11:59 PM
Unknown Object (File)
Nov 20 2024, 11:59 PM
Unknown Object (File)
Nov 20 2024, 11:59 PM
Unknown Object (File)
Nov 20 2024, 11:59 PM
View All Files
Subscribers
wblock
Doc Committers

Details

Reviewers
wblock
Group Reviewers
Doc Committers
Commits
rS274723: Make the auto_master(5) man page clearer on how auto_master
Summary

Make the auto_master(5) man page clearer on how auto_master and map files work together, and add example for smbfs.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

trasz updated this revision to Diff 2446.Nov 18 2014, 10:34 AM
trasz retitled this revision from to Misc fixes for auto_master(5).
trasz updated this object.
trasz edited the test plan for this revision. (Show Details)
trasz added a reviewer: Doc Committers.
trasz added a subscriber: Doc Committers.
wblock added a subscriber: wblock.Nov 18 2014, 3:42 PM
wblock added inline comments.
auto_master.5
37

s/of/of the/

139

s/as/as an/

141

s/Default/The default/

143

Might be good to use one of the quoting macros here. .Ql for quoted literal, maybe. As a reader, it's sometimes hard to tell whether the quotes should be included or are just there to identify the value.

181

Nice!

trasz updated this revision to Diff 2457.Nov 19 2014, 9:56 AM

Fixes from wblock@.

wblock added inline comments.Nov 19 2014, 4:21 PM
auto_master.5
19

Something weird here: "is used by the fstype is used to"

Not really sure what that is trying to say even without the second "is used".

trasz added inline comments.Nov 19 2014, 4:36 PM
auto_master.5
19

Hm, looks like phab got confused somehow, and mixed two diff chunks together. In the diff looks like this:

The
.Nm
configuration file is used by the
@@ -132,8 +136,12 @@
.Li fstype
is used to specify filesystem type.

wblock added inline comments.Nov 19 2014, 4:45 PM
auto_master.5
183

s/for/for a/

trasz updated this revision to Diff 2460.Nov 19 2014, 5:56 PM
wblock accepted this revision.Nov 19 2014, 6:01 PM
wblock added a reviewer: wblock.

Works for me. Before commit, please run igor -R on it, and also mandoc -tlint.

This revision is now accepted and ready to land.Nov 19 2014, 6:01 PM
trasz added a comment.Nov 19 2014, 6:17 PM

Hm, igor complains:

auto_master.5:36:.Sh DESCRIPTION used here:but .Sh SYNOPSIS has not been defined

Should I just s/DESCRIPTION/SYNOPSIS/?

wblock added a comment.Nov 19 2014, 7:01 PM
In D1184#16, @trasz wrote:

Hm, igor complains:

auto_master.5:36:.Sh DESCRIPTION used here:but .Sh SYNOPSIS has not been defined

Should I just s/DESCRIPTION/SYNOPSIS/?

No, a few manual pages do not have a synopsis. It's fine for this one.

trasz closed this revision.Nov 19 2014, 7:47 PM
trasz updated this revision to Diff 2464.

Closed by commit rS274723 (authored by @trasz).

Revision Contents
Changeset List

PathSize
25 lines

Diff 2446

View Options

auto_master.5

Loading...