Page MenuHomeFreeBSD

Misc fixes for auto_master(5)
ClosedPublic

Authored by trasz on Nov 18 2014, 10:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 7:51 AM
Unknown Object (File)
Wed, Nov 20, 11:59 PM
Unknown Object (File)
Wed, Nov 20, 11:59 PM
Unknown Object (File)
Wed, Nov 20, 11:59 PM
Unknown Object (File)
Wed, Nov 20, 11:59 PM
Unknown Object (File)
Wed, Nov 20, 11:36 PM
Unknown Object (File)
Tue, Nov 5, 12:07 PM
Unknown Object (File)
Tue, Nov 5, 12:00 PM

Details

Summary

Make the auto_master(5) man page clearer on how auto_master and map files work together, and add example for smbfs.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

trasz retitled this revision from to Misc fixes for auto_master(5).
trasz updated this object.
trasz edited the test plan for this revision. (Show Details)
trasz added a reviewer: Doc Committers.
trasz added a subscriber: Doc Committers.
wblock added inline comments.
auto_master.5
37 ↗(On Diff #2446)

s/of/of the/

139 ↗(On Diff #2446)

s/as/as an/

141 ↗(On Diff #2446)

s/Default/The default/

143 ↗(On Diff #2446)

Might be good to use one of the quoting macros here. .Ql for quoted literal, maybe. As a reader, it's sometimes hard to tell whether the quotes should be included or are just there to identify the value.

181 ↗(On Diff #2446)

Nice!

auto_master.5
19 ↗(On Diff #2457)

Something weird here: "is used by the fstype is used to"

Not really sure what that is trying to say even without the second "is used".

auto_master.5
19 ↗(On Diff #2457)

Hm, looks like phab got confused somehow, and mixed two diff chunks together. In the diff looks like this:

The
.Nm
configuration file is used by the
@@ -132,8 +136,12 @@
.Li fstype
is used to specify filesystem type.

auto_master.5
183 ↗(On Diff #2457)

s/for/for a/

wblock added a reviewer: wblock.

Works for me. Before commit, please run igor -R on it, and also mandoc -tlint.

This revision is now accepted and ready to land.Nov 19 2014, 6:01 PM

Hm, igor complains:

auto_master.5:36:.Sh DESCRIPTION used here:but .Sh SYNOPSIS has not been defined

Should I just s/DESCRIPTION/SYNOPSIS/?

In D1184#16, @trasz wrote:

Hm, igor complains:

auto_master.5:36:.Sh DESCRIPTION used here:but .Sh SYNOPSIS has not been defined

Should I just s/DESCRIPTION/SYNOPSIS/?

No, a few manual pages do not have a synopsis. It's fine for this one.

trasz updated this revision to Diff 2464.

Closed by commit rS274723 (authored by @trasz).