Corrected handling of fifth parameter in DTrace's FBT provider for ARM
ClosedPublic
Actions

Authored by graeme.jenkinson_cl.cam.ac.uk on Jan 18 2017, 11:13 AM.

Details

Reviewers

markj
andrew
br

Commits

rS331952: MFC r312378 by andrew:
rS312378: Use the kernel stack in the ARM FBT DTrace provider. This is used to find

Summary

DTrace's FBT for ARM attempts to access the user stack pointer, in order to provide the fifth parameter in the call to dtrace_probe. This results in a translation error.

Test Plan

Verified the correct operation of the FBT provider on BeagleBone Black whilst instrumenting fbt::malloc:entry, fbt::vm_fault:entry and fbt:::.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

graeme.jenkinson_cl.cam.ac.uk updated this revision to Diff 24151.Jan 18 2017, 11:13 AM

graeme.jenkinson_cl.cam.ac.uk retitled this revision from to Corrected handling of fifth parameter in DTrace's FBT provider for ARM .

graeme.jenkinson_cl.cam.ac.uk updated this object.

graeme.jenkinson_cl.cam.ac.uk edited the test plan for this revision. (Show Details)

graeme.jenkinson_cl.cam.ac.uk added reviewers: markj, br, andrew.

graeme.jenkinson_cl.cam.ac.uk set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJan 18 2017, 11:13 AM

andrew accepted this revision.Jan 18 2017, 12:02 PM

andrew edited edge metadata.

This revision is now accepted and ready to land.Jan 18 2017, 12:02 PM

Closed by commit rS312378: Use the kernel stack in the ARM FBT DTrace provider. This is used to find (authored by andrew). · Explain WhyJan 18 2017, 1:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

cddl/

dev/

fbt/

arm/

fbt_isa.c

2 lines

Diff 24151

View Options

sys/cddl/dev/fbt/arm/fbt_isa.c

Corrected handling of fifth parameter in DTrace's FBT provider for ARM ClosedPublicActions