loader: efi devpath api usage should be more aware of NULL pointers
ClosedPublic
Actions

Authored by tsoome on Jan 16 2017, 9:19 PM.

Details

Reviewers

jhb
allanjude
imp

Commits

rS312374: loader: efi devpath api usage should be more aware of NULL pointers

Summary

As the efi_devpath_last_node() and efi_devpath_trim() can return NULL
pointers, the consumers of this API should check the the NULL pointers.

Same for efinet_dev_init() using calloc().

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6807
Build 7015: arc lint + arc unit

Event Timeline

tsoome updated this revision to Diff 24083.Jan 16 2017, 9:19 PM

tsoome retitled this revision from to loader: efi devpath api usage should be more aware of NULL pointers.

tsoome updated this object.

tsoome edited the test plan for this revision. (Show Details)

tsoome added reviewers: imp, allanjude, jhb.

jhb accepted this revision.Jan 17 2017, 7:03 PM

jhb edited edge metadata.

This revision is now accepted and ready to land.Jan 17 2017, 7:03 PM

Approved for commit

Closed by commit rS312374: loader: efi devpath api usage should be more aware of NULL pointers (authored by tsoome). · Explain WhyJan 18 2017, 8:18 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

boot/

efi/

libefi/

devpath.c

11 lines

efinet.c

32 lines

efipart.c

5 lines

Diff 24083

View Options

sys/boot/efi/libefi/devpath.c

View Options

sys/boot/efi/libefi/efinet.c

View Options

sys/boot/efi/libefi/efipart.c

loader: efi devpath api usage should be more aware of NULL pointersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24083

sys/boot/efi/libefi/devpath.c

sys/boot/efi/libefi/efinet.c

sys/boot/efi/libefi/efipart.c

loader: efi devpath api usage should be more aware of NULL pointers
ClosedPublic
Actions

Revision Contents
Changeset List