Page MenuHomeFreeBSD

Do not use read-modify-write on MSC control register.
ClosedPublic

Authored by kan on Dec 28 2016, 7:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 28, 10:49 AM
Unknown Object (File)
Wed, Feb 28, 9:04 AM
Unknown Object (File)
Feb 24 2024, 7:02 PM
Unknown Object (File)
Dec 20 2023, 2:43 AM
Unknown Object (File)
Oct 1 2023, 7:03 PM
Unknown Object (File)
Sep 18 2023, 12:30 AM
Unknown Object (File)
Sep 6 2023, 2:31 AM
Unknown Object (File)
Jun 24 2023, 4:39 PM
Subscribers
None

Details

Reviewers
jmcneill
br
Group Reviewers
MIPS
Summary

The register is write-only, so just write only bits we want.

Submitted by: jmcneil

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kan retitled this revision from to Do not use read-modify-write on MSC control register..
kan updated this object.
kan edited the test plan for this revision. (Show Details)
kan set the repository for this revision to rS FreeBSD src repository - subversion.
kan added subscribers: jmcneill_invisible.ca, MIPS, br.
sys/mips/ingenic/jz4780_mmc.c
728

I changed this to two separate writes. In section 32.8.4 of the PM it lists "start the clock" and "start the operation" as separate steps.

sys/mips/ingenic/jz4780_mmc.c
728

Linux does it in one step too, so I won't change that.

kan marked an inline comment as done.Dec 28 2016, 7:24 PM
kan removed rS FreeBSD src repository - subversion as the repository for this revision.

Missed one more place

jmcneill edited edge metadata.
This revision is now accepted and ready to land.Dec 28 2016, 7:30 PM
br edited edge metadata.