Page MenuHomeFreeBSD
Differential D8892

ATFify the gnop tests
ClosedPublic
Actions

Authored by asomers on Dec 23 2016, 5:35 AM.
Tags
None
Referenced Files
F131722141: D8892.id23429.diff
Fri, Oct 10, 3:42 PM
F131721975: D8892.id23213.diff
Fri, Oct 10, 3:40 PM
F131712718: D8892.diff
Fri, Oct 10, 1:46 PM
Unknown Object (File)
Sat, Oct 4, 3:12 AM
Unknown Object (File)
Fri, Sep 19, 8:52 PM
Unknown Object (File)
Wed, Sep 17, 7:35 PM
Unknown Object (File)
Wed, Sep 17, 12:26 AM
Unknown Object (File)
Mon, Sep 15, 4:01 AM
View All 73 Files
Subscribers
imp

Details

Reviewers
ngie
Commits
rS310803: ATFify the gnop tests
Summary

ATFify the gnop tests

Also, add test cases for the -p, -P, and -s options to gnop create

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningtests/sys/geom/class/nop/nop_test.sh:CHMOD1Invalid Executable
Unit
No Test Coverage
Build Status
Buildable 6363
Build 6602: arc lint + arc unit

Event Timeline

asomers updated this revision to Diff 23213.Dec 23 2016, 5:35 AM
asomers retitled this revision from to ATFify the gnop tests.
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added a reviewer: ngie.
Herald added a subscriber: imp. · View Herald TranscriptDec 23 2016, 5:35 AM
ngie accepted this revision.Dec 26 2016, 6:37 AM
ngie edited edge metadata.
ngie added inline comments.
tests/sys/geom/class/nop/nop_test.sh
2

Could you please add licensing info?

78

-s not-exit:0 is better

101

atf_check_equal would be better.

This revision is now accepted and ready to land.Dec 26 2016, 6:37 AM
Closed by commit rS310803: ATFify the gnop tests (authored by asomers). · Explain WhyDec 30 2016, 2:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
tests/
sys/
geom/
class/
nop/
9 lines
147 lines

Diff 23213

View Options

tests/sys/geom/class/nop/1_test.sh

Loading...
View Options

tests/sys/geom/class/nop/2_test.sh

Loading...
View Options

tests/sys/geom/class/nop/Makefile

Loading...
View Options

tests/sys/geom/class/nop/conf.sh

Loading...
View Options

tests/sys/geom/class/nop/nop_test.sh

Loading...