Page MenuHomeFreeBSD

ATFify the gnop tests
ClosedPublic

Authored by asomers on Dec 23 2016, 5:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 4, 3:12 AM
Unknown Object (File)
Fri, Sep 19, 8:52 PM
Unknown Object (File)
Wed, Sep 17, 7:35 PM
Unknown Object (File)
Wed, Sep 17, 12:26 AM
Unknown Object (File)
Mon, Sep 15, 4:01 AM
Unknown Object (File)
Sun, Sep 14, 1:53 PM
Unknown Object (File)
Sun, Sep 14, 11:50 AM
Unknown Object (File)
Sun, Sep 14, 2:09 AM
Subscribers

Details

Summary

ATFify the gnop tests

Also, add test cases for the -p, -P, and -s options to gnop create

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers retitled this revision from to ATFify the gnop tests.
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added a reviewer: ngie.
ngie edited edge metadata.
ngie added inline comments.
tests/sys/geom/class/nop/nop_test.sh
2 ↗(On Diff #23213)

Could you please add licensing info?

78 ↗(On Diff #23213)

-s not-exit:0 is better

101 ↗(On Diff #23213)

atf_check_equal would be better.

This revision is now accepted and ready to land.Dec 26 2016, 6:37 AM
This revision was automatically updated to reflect the committed changes.