Differential D8872

Make running tests in contrib build optional for audio/logitechmediaserver
ClosedPublic
Actions

Authored by mark_tranquillussoftware.co.uk on Dec 20 2016, 7:34 PM.

Details

Reviewers

woodsb02

Commits

rP433400: audio/logitechmediaserver: Make testing vendor perl modules optional

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mark_tranquillussoftware.co.uk updated this revision to Diff 23153.Dec 20 2016, 7:34 PM

mark_tranquillussoftware.co.uk retitled this revision from to Make running tests in contrib build optional for audio/logitechmediaserver.

mark_tranquillussoftware.co.uk updated this object.

mark_tranquillussoftware.co.uk edited the test plan for this revision. (Show Details)

mark_tranquillussoftware.co.uk set the repository for this revision to rP FreeBSD ports repository.

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptDec 20 2016, 7:34 PM

We try to not have negative options, it would be better to have a "TEST" one and reverse the logic.

Change to positive option as per comments

Hi Mark,
Can you please explain why you would want to skip the tests for the Perl modules that were build by the vendor instructions/source? Surely these tests are intended to confirm the Perl modules function correctly?
Thanks,
Ben

In D8872#193773, @woodsb02 wrote:

Hi Mark,
Can you please explain why you would want to skip the tests for the Perl modules that were build by the vendor instructions/source? Surely these tests are intended to confirm the Perl modules function correctly?

I've had multiple reports that the loopback tests are failing when folks are building inside a jail as they're not getting the address they expect. This avoids that problem.

Looks ok to me

This revision is now accepted and ready to land.Feb 5 2017, 12:44 PM

Closed by commit rP433400: audio/logitechmediaserver: Make testing vendor perl modules optional (authored by woodsb02). · Explain WhyFeb 5 2017, 1:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

audio/

logitechmediaserver/

Makefile

6 lines

Diff 23153

View Options

audio/logitechmediaserver/Makefile

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 Lines	struct msdosfsmount {
u_long pm_fatblocksec; /* size of FAT blocks in sectors */		u_long pm_fatblocksec; /* size of FAT blocks in sectors */
u_long pm_fatsize; /* size of FAT in bytes */		u_long pm_fatsize; /* size of FAT in bytes */
uint32_t pm_fatmask; /* mask to use for FAT numbers */		uint32_t pm_fatmask; /* mask to use for FAT numbers */
u_long pm_fsinfo; /* fsinfo block number */		u_long pm_fsinfo; /* fsinfo block number */
u_long pm_nxtfree; /* next place to search for a free cluster */		u_long pm_nxtfree; /* next place to search for a free cluster */
u_int pm_fatmult; /* these 2 values are used in FAT */		u_int pm_fatmult; /* these 2 values are used in FAT */
u_int pm_fatdiv; /* offset computation */		u_int pm_fatdiv; /* offset computation */
u_int pm_curfat; /* current FAT for FAT32 (0 otherwise) */		u_int pm_curfat; /* current FAT for FAT32 (0 otherwise) */
		int pm_rootdirfree; /* number of free slots in FAT12/16 root directory */
u_int pm_inusemap; / ptr to bitmap of in-use clusters */		u_int pm_inusemap; / ptr to bitmap of in-use clusters */
uint64_t pm_flags; /* see below */		uint64_t pm_flags; /* see below */
void pm_u2w; / Local->Unicode iconv handle */		void pm_u2w; / Local->Unicode iconv handle */
void pm_w2u; / Unicode->Local iconv handle */		void pm_w2u; / Unicode->Local iconv handle */
void pm_u2d; / Unicode->DOS iconv handle */		void pm_u2d; / Unicode->DOS iconv handle */
void pm_d2u; / DOS->Local iconv handle */		void pm_d2u; / DOS->Local iconv handle */
#ifndef MAKEFS		#ifndef MAKEFS
		seAuthorUnsubmitted Done Inline Actions This could also be an int or u:_int. The acceptable range is 0..65535. se: This could also be an int or u:_int. The acceptable range is 0..65535.
		seAuthorUnsubmitted Done Inline Actions The type of pm_rootdirfree should be int to allow -1 to be returned as an error indicator. se: The type of pm_rootdirfree should be int to allow -1 to be returned as an error indicator.
struct lock pm_fatlock; /* lockmgr protecting allocations */		struct lock pm_fatlock; /* lockmgr protecting allocations */
struct lock pm_checkpath_lock; /* protects doscheckpath result */		struct lock pm_checkpath_lock; /* protects doscheckpath result */
struct task pm_rw2ro_task; /* context for emergency remount ro */		struct task pm_rw2ro_task; /* context for emergency remount ro */
#endif		#endif
};		};

/*		/*
* A 64-bit file number and the 32-bit file number to which it is mapped,		* A 64-bit file number and the 32-bit file number to which it is mapped,
▲ Show 20 Lines • Show All 90 Lines • ▼ Show 20 Lines
/*		/*
* Calculate block number for directory entry at cluster dirclu, offset		* Calculate block number for directory entry at cluster dirclu, offset
* dirofs		* dirofs
*/		*/
#define detobn(pmp, dirclu, dirofs) \		#define detobn(pmp, dirclu, dirofs) \
((dirclu) == MSDOSFSROOT \		((dirclu) == MSDOSFSROOT \
? roottobn((pmp), (dirofs)) \		? roottobn((pmp), (dirofs)) \
: cntobn((pmp), (dirclu)))		: cntobn((pmp), (dirclu)))

		/*
		seAuthorUnsubmitted Done Inline Actions The comment is wrong and applies to a prior version of the patch: the number of free entries is counted (here and in the macro below), se: The comment is wrong and applies to a prior version of the patch: the number of free entries is…
		seAuthorUnsubmitted Done Inline Actions The comment needs to be fixed - has been forgotten when I prepared the latest patch. se: The comment needs to be fixed - has been forgotten when I prepared the latest patch.
		* Increment the number of used entries in a fixed size FAT12/16 root
		* directory
		*/
		#define rootde_alloced(dep) \
		if ((dep)->de_StartCluster == MSDOSFSROOT) \
		(dep)->de_pmp->pm_rootdirfree--;

		/*
		* Decrement the number of used entries in a fixed size FAT12/16 root
		* directory
		*/
		#define rootde_freed(dep) \
		if ((dep)->de_StartCluster == MSDOSFSROOT) \
		(dep)->de_pmp->pm_rootdirfree++;

#define MSDOSFS_LOCK_MP(pmp) \		#define MSDOSFS_LOCK_MP(pmp) \
lockmgr(&(pmp)->pm_fatlock, LK_EXCLUSIVE, NULL)		lockmgr(&(pmp)->pm_fatlock, LK_EXCLUSIVE, NULL)
#define MSDOSFS_UNLOCK_MP(pmp) \		#define MSDOSFS_UNLOCK_MP(pmp) \
lockmgr(&(pmp)->pm_fatlock, LK_RELEASE, NULL)		lockmgr(&(pmp)->pm_fatlock, LK_RELEASE, NULL)
#define MSDOSFS_ASSERT_MP_LOCKED(pmp) \		#define MSDOSFS_ASSERT_MP_LOCKED(pmp) \
lockmgr_assert(&(pmp)->pm_fatlock, KA_XLOCKED)		lockmgr_assert(&(pmp)->pm_fatlock, KA_XLOCKED)

▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines

Make running tests in contrib build optional for audio/logitechmediaserverClosedPublicActions