Page MenuHomeFreeBSD
Differential D8872

Make running tests in contrib build optional for audio/logitechmediaserver
ClosedPublic
Actions

Authored by mark_tranquillussoftware.co.uk on Dec 20 2016, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 11:41 AM
Unknown Object (File)
Sat, Nov 23, 4:55 PM
Unknown Object (File)
Thu, Nov 21, 3:14 AM
Unknown Object (File)
Wed, Nov 20, 3:33 PM
Unknown Object (File)
Fri, Nov 15, 9:28 AM
Unknown Object (File)
Thu, Nov 14, 2:44 PM
Unknown Object (File)
Fri, Nov 8, 7:22 AM
Unknown Object (File)
Thu, Nov 7, 6:42 PM
View All Files
Subscribers
mat
woodsb02
Contributor Reviewers (ports)

Details

Reviewers
woodsb02
Commits
rP433400: audio/logitechmediaserver: Make testing vendor perl modules optional

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mark_tranquillussoftware.co.uk updated this revision to Diff 23153.Dec 20 2016, 7:34 PM
mark_tranquillussoftware.co.uk retitled this revision from to Make running tests in contrib build optional for audio/logitechmediaserver.
mark_tranquillussoftware.co.uk updated this object.
mark_tranquillussoftware.co.uk edited the test plan for this revision. (Show Details)
mark_tranquillussoftware.co.uk set the repository for this revision to rP FreeBSD ports repository.
Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptDec 20 2016, 7:34 PM
mat added a comment.Dec 21 2016, 8:23 AM

We try to not have negative options, it would be better to have a "TEST" one and reverse the logic.

mark_tranquillussoftware.co.uk updated this revision to Diff 23395.Dec 29 2016, 11:21 AM

Change to positive option as per comments

woodsb02 added a subscriber: woodsb02.Jan 30 2017, 11:30 AM

Hi Mark,
Can you please explain why you would want to skip the tests for the Perl modules that were build by the vendor instructions/source? Surely these tests are intended to confirm the Perl modules function correctly?
Thanks,
Ben

mark_tranquillussoftware.co.uk added a comment.Jan 30 2017, 12:56 PM
In D8872#193773, @woodsb02 wrote:

Hi Mark,
Can you please explain why you would want to skip the tests for the Perl modules that were build by the vendor instructions/source? Surely these tests are intended to confirm the Perl modules function correctly?

I've had multiple reports that the loopback tests are failing when folks are building inside a jail as they're not getting the address they expect. This avoids that problem.

woodsb02 accepted this revision.Feb 5 2017, 12:44 PM
woodsb02 added a reviewer: woodsb02.

Looks ok to me

This revision is now accepted and ready to land.Feb 5 2017, 12:44 PM
Closed by commit rP433400: audio/logitechmediaserver: Make testing vendor perl modules optional (authored by woodsb02). · Explain WhyFeb 5 2017, 1:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
audio/
logitechmediaserver/
7 lines

Diff 24763

View Options

head/audio/logitechmediaserver/Makefile

Loading...