Differential D8784

jz4780: fix clk_gen divider calculation and rounding
ClosedPublic
Actions

Authored by jmcneill on Dec 14 2016, 1:49 AM.

Details

Reviewers

kan

Commits

rS310307: Choose the closes matching divider instead of one that results in a

Summary

jz4780_clk_gen_set_freq always sets a frequency >= target. Included:

By default choose the closest matching divider instead of one that results in a frequency >= target
Fix inverted rounding logic

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jmcneill updated this revision to Diff 22896.Dec 14 2016, 1:49 AM

jmcneill retitled this revision from to jz4780: fix clk_gen divider calculation and rounding.

jmcneill updated this object.

jmcneill edited the test plan for this revision. (Show Details)

jmcneill added a reviewer: kan.

jmcneill set the repository for this revision to rS FreeBSD src repository - subversion.

jmcneill added a project: MIPS.

Herald added a subscriber: imp. · View Herald TranscriptDec 14 2016, 1:49 AM

jmcneill added a child revision: D8827: jz4780 LCD controller driver.Dec 17 2016, 2:00 PM

I just can say that I saw some problem in that area configuring MMC device for X1000 processor a month ago and was thinking about similar change.

kan accepted this revision.Dec 17 2016, 9:29 PM

kan edited edge metadata.

This revision is now accepted and ready to land.Dec 17 2016, 9:29 PM

Closed by commit rS310307: Choose the closes matching divider instead of one that results in a (authored by jmcneill). · Explain WhyDec 20 2016, 1:37 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

mips/

ingenic/

jz4780_clk_gen.c

14 lines

Diff 23119

View Options

head/sys/mips/ingenic/jz4780_clk_gen.c

jz4780: fix clk_gen divider calculation and roundingClosedPublicActions