Paths

Table of Contentst

Use correct sscanf() format string for uint64_t
ClosedPublic
Actions

Authored by dim on Dec 17 2016, 6:07 PM.

Details

Reviewers

• hselasky
rstone

Commits

rS315328: MFC r310232:
rS310232: After r310171, the kernel version of sscanf() has format string checking

Summary

After rS310171, the kernel version of sscanf() now has format string
checking enabled. This now results in a -Werror warning in mlx4ib:

/usr/src/sys/modules/mlx4ib/../../dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c:90:22: error: format specifies type 'unsigned long long *' but the argument has type 'u64 *' (aka 'unsigned long *') [-Werror,-Wformat]
        sscanf(buf, "%llx", &sysadmin_ag_val);
                 ~~~~   ^~~~~~~~~~~~~~~~

Since u64 is a uint64_t, let's use the SCNx64 macro from inttypes.h
instead.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dim updated this revision to Diff 23034.Dec 17 2016, 6:07 PM

dim retitled this revision from to Use correct sscanf() format string for uint64_t.

dim updated this object.

dim edited the test plan for this revision. (Show Details)

dim added reviewers: • hselasky, rstone.

Herald added a subscriber: imp. · View Herald TranscriptDec 17 2016, 6:07 PM

dim updated this object.Dec 17 2016, 6:08 PM

Is machine/_inttypes.h the correct header file to include?

I think it is also fine to change the sysadmin_ag_val to unsigned long long, which is currently 64-bit for i386 and amd64 which the mlx4 driver is compiled on.

Don't forget to MFC.

--HPS

This revision is now accepted and ready to land.Dec 18 2016, 8:44 AM

In D8831#182872, @hselasky wrote:

Is machine/_inttypes.h the correct header file to include?

This is what other drivers appear to include, if they want to get at PRI/SCN macros. Though this isn't a Linux thing.

I think it is also fine to change the sysadmin_ag_val to unsigned long long, which is currently 64-bit for i386 and amd64 which the mlx4 driver is compiled on.

Yes, if that is also acceptable, we don't need the additional include.

Just change sysadmin_ag_val to unsigned long long instead.

This revision now requires review to proceed.Dec 18 2016, 3:18 PM

Closed by commit rS310232: After r310171, the kernel version of sscanf() has format string checking (authored by dim). · Explain WhyDec 18 2016, 3:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

mlx4/

mlx4_ib/

mlx4_ib_sysfs.c

2 lines

Diff 23058

View Options

head/sys/dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c

Use correct sscanf() format string for uint64_tClosedPublicActions