Details

Reviewers

emaste
kan
jmcneill
imp

Commits

rS310330: Add xDMA -- the DMA abstraction layer, initial verison.

Summary

Ideas for improvement:

SoftDMA - when we have no real dma yet, but already want to use xDMA
Introduce capabilites, so xDMA knows what the transfer types supported by hardware DMA controller, how many data can be copied by single descriptor, etc.
Callback provided with some information, e.g. how many data were actually copied and any errors occurred during transfer
Scatter-Gathering transfer type (WIP)
Non-FDT setup, i.e. real dma controller register itself to xDMA
Might be useful to have xdma interrupt thread, so callbacks can be optionally provided not in the interrupt time, but after
Requests enqueuing support ? not sure if we need that

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

br updated this revision to Diff 22952.Dec 15 2016, 3:38 PM

br retitled this revision from to DMA abstaction layer aka xDMA.

br updated this object.

br edited the test plan for this revision. (Show Details)

br added a reviewer: kan.

br added a reviewer: jmcneill.Dec 15 2016, 3:55 PM

I've found a couple of typos in comments.

sys/dev/xdma/xdma.c
422	s/decsriptors/descriptors/
469	s/decsriptors/descriptors/
sys/dev/xdma/xdma_fdt_test.c
311	s/succeded/succeeded/

br added a child revision: D8808: jz4780 AIC audio driver.Dec 15 2016, 4:10 PM

fix typos repored by bcr@
add man page

br added a child revision: D8817: jz4780 PDMA driver.Dec 16 2016, 3:56 PM

br updated this object.Dec 16 2016, 4:06 PM

br updated this object.Dec 16 2016, 4:51 PM

br added a reviewer: imp.

br updated this object.

jmcneill added inline comments.Dec 16 2016, 8:22 PM

sys/dev/xdma/xdma_if.m
67	I think this should be pcell_t

Thinking about this some more. For Allwinner (ARM) we have a private sunxi_dma_if that is used. The config structure has some additional fields:

struct sunxi_dma_config {
	unsigned int dst_width;
	unsigned int dst_burst_len;
	unsigned int dst_drqtype;
	bool dst_noincr;
	unsigned int dst_blksize;	/* DDMA-only */
	unsigned int dst_wait_cyc;	/* DDMA-only */
	unsigned int src_width;
	unsigned int src_burst_len;
	unsigned int src_drqtype;
	bool src_noincr;
	unsigned int src_blksize;	/* DDMA-only */
	unsigned int src_wait_cyc;	/* DDMA-only */
};

Is the expectation that as more fields are required we will grow xdma_channel_config?

Is the expectation that as more fields are required we will grow xdma_channel_config?

Sure! we can grow any time if required.

use pcell_t instead of phandle_t asnoticed by jmcneill@

sys/dev/xdma/xdma_if.m
67	you right, thanks !

br updated this revision to Diff 23055.Dec 18 2016, 2:21 PM

br added a reviewer: emaste.Dec 18 2016, 10:33 PM

Closed by commit rS310330: Add xDMA -- the DMA abstraction layer, initial verison. (authored by br). · Explain WhyDec 20 2016, 6:02 PM

This revision was automatically updated to reflect the committed changes.

DMA abstaction layer aka xDMA
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 23055

share/man/man4/xdma.4

sys/conf/files

sys/dev/xdma/xdma.h

sys/dev/xdma/xdma.c

sys/dev/xdma/xdma_fdt_test.c

sys/dev/xdma/xdma_if.m

DMA abstaction layer aka xDMAClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 23055

share/man/man4/xdma.4

sys/conf/files

sys/dev/xdma/xdma.h

sys/dev/xdma/xdma.c

sys/dev/xdma/xdma_fdt_test.c

sys/dev/xdma/xdma_if.m

DMA abstaction layer aka xDMA
ClosedPublic
Actions

Revision Contents
Changeset List