Page MenuHomeFreeBSD
Differential D8815

Add a 'force' option for non-interactive crontab removal
ClosedPublic
Actions

Authored by sam_samgwydir.com on Dec 16 2016, 1:26 AM.
Tags
None
Referenced Files
F106988862: D8815.id23003.diff
Wed, Jan 8, 2:45 PM
Unknown Object (File)
Tue, Jan 7, 4:22 AM
Unknown Object (File)
Sun, Jan 5, 5:43 PM
Unknown Object (File)
Sun, Jan 5, 3:03 PM
Unknown Object (File)
Thu, Jan 2, 7:31 PM
Unknown Object (File)
Thu, Jan 2, 11:47 AM
Unknown Object (File)
Sat, Dec 14, 4:52 PM
Unknown Object (File)
Dec 4 2024, 2:28 PM
View All Files
Subscribers
cem
imp
wblock
Contributor Reviews (src)

Details

Reviewers
cem
Group Reviewers
manpages
Commits
rS310329: Add a 'force' option for non-interactive crontab removal
Summary

While converting a user provisioning tool from use in linux to FreeBSD it turned out crontab -r was interactive (requiring 'y' to remove). This diff adds a '-f' option to force crontab to be non-interactive.

Test Plan

Tested by adding a test user, creating a crontab for them and attempting to remove it with a without '-f' set.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sam_samgwydir.com updated this revision to Diff 22971.Dec 16 2016, 1:26 AM
sam_samgwydir.com retitled this revision from to Add a 'force' option for non-interactive crontab removal.
sam_samgwydir.com updated this object.
sam_samgwydir.com edited the test plan for this revision. (Show Details)
sam_samgwydir.com set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a reviewer: manpages. · View Herald TranscriptDec 16 2016, 1:26 AM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
cem added a subscriber: cem.Dec 16 2016, 1:29 AM

Please upload a diff with full context (either use the arc tool, or generate a patch with diff -U9999999).

usr.sbin/cron/crontab/crontab.c
66

Spacing between 'int' and 'fflag' looks off relative to other variables nearby.

sam_samgwydir.com updated this revision to Diff 22972.Dec 16 2016, 1:35 AM
sam_samgwydir.com edited edge metadata.

Added more context.

Also fixed spacing before 'fflag'

Herald edited edge metadata. · View Herald TranscriptDec 16 2016, 1:35 AM
sam_samgwydir.com updated this revision to Diff 22980.Dec 16 2016, 1:51 AM
sam_samgwydir.com edited edge metadata.
sam_samgwydir.com removed rS FreeBSD src repository - subversion as the repository for this revision.
sam_samgwydir.com marked an inline comment as done.

Fixed spacing. There was an extra space that I did not account for.

cem accepted this revision.Dec 16 2016, 1:56 AM
cem added a reviewer: cem.

Do you have a commit bit, or do you need me to commit this for you? Thanks!

usr.sbin/cron/crontab/crontab.1
20

In general, bump .Dd to the date you changed the manual page.

usr.sbin/cron/crontab/crontab.c
289

I see. You could also workaround this by running crontab ... < /dev/null. I still like your -f flag, though.

This revision is now accepted and ready to land.Dec 16 2016, 1:56 AM
sam_samgwydir.com updated this revision to Diff 22983.EditedDec 16 2016, 2:04 AM
sam_samgwydir.com edited edge metadata.
sam_samgwydir.com set the repository for this revision to rS FreeBSD src repository - subversion.

Fixed date in manpage and no I don't have a bit -- if you could commit that would be great.

This revision now requires review to proceed.Dec 16 2016, 2:04 AM
cem accepted this revision.Dec 16 2016, 2:07 AM
cem edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 2:07 AM
sam_samgwydir.com updated this revision to Diff 23003.Dec 16 2016, 4:36 PM
sam_samgwydir.com edited edge metadata.
sam_samgwydir.com marked an inline comment as done.

Diff was broken -- now fixed.

This revision now requires review to proceed.Dec 16 2016, 4:36 PM
wblock added a subscriber: wblock.Dec 16 2016, 6:06 PM
wblock added inline comments.
usr.sbin/cron/crontab/crontab.1
35

This implies that -f is used instead of one of the other arguments. I suggest

{
.Fl l |
.Fl r Op Fl f
|
.Fl e
}
101

This should probably not be a separate item, since it is only used with -r.

Add
.Fl f
to force the removal without a prompt for confirmation.
sam_samgwydir.com updated this revision to Diff 23007.Dec 16 2016, 7:03 PM
sam_samgwydir.com edited edge metadata.

Fixed man page according to feedback. Also fixed usage() to reflect those changes.

sam_samgwydir.com marked 3 inline comments as done.Dec 17 2016, 5:56 PM
sam_samgwydir.com added inline comments.
usr.sbin/cron/crontab/crontab.c
289

Yeah we were piping in yes but it wasn't until I got into the code I saw there was some way to make it non-interactive, but it's undocumented.

sam_samgwydir.com marked 2 inline comments as done.Dec 17 2016, 5:56 PM
sam_samgwydir.com added a comment.Dec 20 2016, 5:04 PM

This patch is ready to go now -- if someone could commit it that'd be perfect.

Closed by commit rS310329: Add a 'force' option for non-interactive crontab removal (authored by cem). · Explain WhyDec 20 2016, 5:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.sbin/
cron/
crontab/
4 lines
10 lines

Diff 22972

View Options

usr.sbin/cron/crontab/crontab.1

Loading...
View Options

usr.sbin/cron/crontab/crontab.c

Loading...