Page MenuHomeFreeBSD
Differential D1118

Safety belt on -lpthread and -lc
ClosedPublic
Actions

Authored by bapt on Nov 5 2014, 7:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 1:42 AM
Unknown Object (File)
Nov 18 2024, 8:20 AM
Unknown Object (File)
Nov 18 2024, 2:16 AM
Unknown Object (File)
Nov 14 2024, 4:07 AM
Unknown Object (File)
Nov 11 2024, 2:59 PM
Unknown Object (File)
Oct 17 2024, 9:08 PM
Unknown Object (File)
Oct 17 2024, 9:07 PM
Unknown Object (File)
Oct 17 2024, 8:57 PM
View All 55 Files
Subscribers
None

Details

Reviewers
kib
imp
bdrewery
Summary

Ensure that if -lc and -lpthread are found in the LDADD chain they are always
The to last components of the link chain in the following order:
-lpthread then -lc

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bapt updated this revision to Diff 2294.Nov 5 2014, 7:30 PM
bapt retitled this revision from to Safety belt on -lpthread and -lc.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: imp.
Herald added a reviewer: bdrewery. · View Herald TranscriptNov 5 2014, 7:30 PM
bapt added a reviewer: kib.Nov 5 2014, 7:31 PM
kib accepted this revision.Nov 6 2014, 8:41 AM
kib edited edge metadata.

I think this is fine, but please take it with a grain of salt due to my ignorance WRT both build system and make.

Also note that this is good safety belts, but not a complete solution. E.g., it does not help with the problem in r265003, since the buggy order is realized not due to the wrong appearance of -lpthread on the command line, but due to the libraries which required libthr.

This revision is now accepted and ready to land.Nov 6 2014, 8:41 AM
bapt closed this revision.Nov 22 2014, 1:40 PM

Committed

Revision Contents
Changeset List

PathSize
share/
mk/
10 lines

Diff 2294

View Options

share/mk/bsd.libnames.mk

Loading...