Page MenuHomeFreeBSD
Differential D8796

editors/emacs-devel: Update to pull in new concurrency features
ClosedPublic
Actions

Authored by jrm on Dec 14 2016, 3:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 12 2024, 11:39 AM
Unknown Object (File)
Mar 9 2024, 10:30 PM
Unknown Object (File)
Jan 19 2024, 12:48 AM
Unknown Object (File)
Jan 14 2024, 6:37 PM
Unknown Object (File)
Jan 14 2024, 6:37 PM
Unknown Object (File)
Dec 20 2023, 2:45 AM
Unknown Object (File)
Nov 28 2023, 6:17 PM
Unknown Object (File)
Nov 7 2023, 10:34 PM
View All 39 Files
Subscribers
mat

Details

Reviewers
swills
AMDmi3
ashish
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Commits
rP429394: editors/emacs-devel: Update to pull in new concurrency features.
Summary

editors/emacs-devel: Update to pull in new concurrency features

While here, update to minimize the differences with editors/emacs.

  • Do not require GCC to work around a clang bug. The OS versions for which this was relevant are no longer supported.
  • The check for X11 is handled with the X11 option and _IMPLIES, so remove the redundant .if logic.
Test Plan

portlint -C: Ok
testport: OK (poudriere: 9.3-RELEASE-p48, i386, default options)
testport: OK (poudriere: 9.3-RELEASE-p48, amd64, default options)
testport: OK (poudriere: 10.3-RELEASE-p10, i386, default options)
testport: OK (poudriere: 10.3-RELEASE-p10, amd64, default options)
testport: OK (poudriere: 11.0-RELEASE-p1, i386, default options)
testport: OK (poudriere: 11.0-RELEASE-p1, amd64, default options)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 6239
Build 6482: arc lint + arc unit

Event Timeline

jrm updated this revision to Diff 22917.Dec 14 2016, 3:39 PM
jrm retitled this revision from to editors/emacs-devel: Update to pull in new concurrency features.
jrm updated this object.
jrm edited the test plan for this revision. (Show Details)
jrm added reviewers: ashish, swills, AMDmi3.
Herald added a subscriber: mat. · View Herald TranscriptDec 14 2016, 3:39 PM
jrm edited edge metadata.Dec 18 2016, 1:34 PM
swills accepted this revision.Dec 20 2016, 4:29 PM
swills edited edge metadata.

Approved

ashish added a comment.Dec 21 2016, 3:41 AM

Looks good, although I suggest adding a on-by-default THREADS option to disable thread support for those who want to disable it. Could you please add it ?

Thanks!

ashish added a comment.Dec 21 2016, 3:45 AM

Also need to bump port version in Mk/bsd.emacs.mk. Could you submit a diff for that too ?

Thanks!

AMDmi3 accepted this revision.Dec 21 2016, 2:00 PM
AMDmi3 edited edge metadata.
jrm updated this revision to Diff 23181.Dec 21 2016, 7:07 PM
jrm edited edge metadata.

Add an option for threading and update Mk/bsd.emacs.mk

Owners added a reviewer: O5: Ports Framework.Dec 21 2016, 7:07 PM
Herald added a reviewer: portmgr. · View Herald TranscriptDec 21 2016, 7:07 PM
swills accepted this revision.Dec 21 2016, 9:40 PM
swills edited edge metadata.

Works for me

ashish accepted this revision.Dec 25 2016, 3:19 AM
ashish edited edge metadata.

Looks good now. Thanks for working on this. Please go ahead, and commit.

This revision is now accepted and ready to land.Dec 25 2016, 3:19 AM
Closed by commit rP429394: editors/emacs-devel: Update to pull in new concurrency features. (authored by jrm). · Explain WhyDec 25 2016, 4:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
editors/
emacs-devel/
47 lines
6 lines
14 lines

Diff 22917

View Options

editors/emacs-devel/Makefile

Loading...
View Options

editors/emacs-devel/distinfo

Loading...
View Options

editors/emacs-devel/pkg-plist

Loading...