Page MenuHomeFreeBSD
Differential D8715

Switch libcommon.xsl used to generate security RSS feed to use HTTPS
ClosedPublic
Actions

Authored by sevan on Dec 5 2016, 1:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 3:23 AM
Unknown Object (File)
Dec 11 2023, 5:38 AM
Unknown Object (File)
Nov 13 2023, 3:27 PM
Unknown Object (File)
Oct 25 2023, 11:33 AM
Unknown Object (File)
Oct 4 2023, 8:43 PM
Unknown Object (File)
Aug 13 2023, 11:34 AM
Unknown Object (File)
Jul 25 2023, 3:32 PM
Unknown Object (File)
Jul 25 2023, 9:00 AM
View All 25 Files
Subscribers
gjb

Details

Reviewers
gjb
bcr
Group Reviewers
doceng
Commits
rD49712: Switch from protocol independent URLs to explicitly using HTTPS as they're not
Summary

libcommon.xsl was switched to using protocol independent notation in urls which is not valid for use in RSS.
Patch switches to using HTTPS for URLs (bug #206683)

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sevan updated this revision to Diff 22716.Dec 5 2016, 1:31 PM
sevan retitled this revision from to Switch libcommon.xsl used to generate security RSS feed to use HTTPS.
sevan updated this object.
sevan edited the test plan for this revision. (Show Details)
sevan added a reviewer: bcr.
sevan set the repository for this revision to rD FreeBSD doc repository - subversion.
bcr edited edge metadata.Dec 6 2016, 9:12 AM

Can you add the doceng group to the reviewer list? I think they should at least know about infrastructural changes like this.

sevan added a reviewer: doceng.Dec 6 2016, 12:22 PM

Added doceng group.

gjb added a subscriber: gjb.Dec 6 2016, 2:50 PM

What page(s) are affected? I see no change to the index page when building with your patch applied.

sevan added a comment.Dec 6 2016, 3:22 PM

The security RSS feed , pointing https://www.freebsd.org/security/rss.xml to the W3C Validator reports a couple of said issues, but fetching & viewing the xml feed by itself reveals many more links missing protocol (http or https).
https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fwww.freebsd.org%2Fsecurity%2Frss.xml

gjb accepted this revision.Dec 6 2016, 5:41 PM
gjb added a reviewer: gjb.
This revision is now accepted and ready to land.Dec 6 2016, 5:41 PM
Closed by commit rD49712: Switch from protocol independent URLs to explicitly using HTTPS as they're not (authored by sevan). · Explain WhyDec 6 2016, 7:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
share/
xml/
8 lines

Diff 22716

View Options

share/xml/libcommon.xsl

Loading...