Page MenuHomeFreeBSD
Differential D8624

Add tunable to disable destructive dtrace Security
ClosedPublic
Actions

Authored by gnn on Nov 23 2016, 4:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 29, 2:16 PM
Unknown Object (File)
Fri, Nov 29, 1:07 PM
Unknown Object (File)
Nov 24 2024, 3:07 AM
Unknown Object (File)
Nov 21 2024, 7:58 AM
Unknown Object (File)
Nov 4 2024, 7:56 PM
Unknown Object (File)
Oct 24 2024, 9:28 PM
Unknown Object (File)
Oct 1 2024, 5:46 AM
Unknown Object (File)
Sep 21 2024, 8:40 AM
View All 58 Files
Subscribers
imp
rstone

Details

Reviewers
markj
rstone
Commits
rS309069: Add tunable to disable destructive dtrace

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6050
Build 6316: arc lint + arc unit

Event Timeline

gnn updated this revision to Diff 22463.Nov 23 2016, 4:47 PM
gnn retitled this revision from to Add tunable to disable destructive dtrace Security.
gnn updated this object.
gnn edited the test plan for this revision. (Show Details)
gnn added a reviewer: markj.
Herald added a subscriber: imp. · View Herald TranscriptNov 23 2016, 4:47 PM
rstone added a subscriber: rstone.Nov 23 2016, 4:50 PM
rstone added inline comments.
sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c
162

is there any reason to make this a global?

rstone accepted this revision.Nov 23 2016, 4:50 PM
rstone added a reviewer: rstone.
rstone added inline comments.
sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c
162

never mind, missed the sysctl

This revision is now accepted and ready to land.Nov 23 2016, 4:50 PM
markj accepted this revision.Nov 23 2016, 5:18 PM
markj edited edge metadata.
markj added inline comments.
sys/cddl/dev/dtrace/dtrace_load.c
60

I thought that a RDTUN sysctl would automatically fetch the tunable value, so I'm surprised that this bit is needed.

gnn marked an inline comment as done.Nov 23 2016, 10:45 PM
Closed by commit rS309069: Add tunable to disable destructive dtrace (authored by gnn). · Explain WhyNov 23 2016, 10:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
cddl/
contrib/
opensolaris/
uts/
common/
dtrace/
4 lines
dev/
dtrace/
13 lines
3 lines

Diff 22463

View Options

sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c

Loading...
View Options

sys/cddl/dev/dtrace/dtrace_load.c

Loading...
View Options

sys/cddl/dev/dtrace/dtrace_sysctl.c

Loading...