Page MenuHomeFreeBSD
Differential D1086

Use the BSD_TO_LINUX_SIGNAL() wherever there is no need to check the ABI as it is known.
ClosedPublic
Actions

Authored by dchagin on Nov 3 2014, 7:03 AM.
Tags
None
Referenced Files
F156546267: D1086.id2234.diff
Thu, May 14, 2:11 PM
F156521182: D1086.id5643.diff
Thu, May 14, 9:19 AM
Unknown Object (File)
Fri, May 8, 4:21 AM
Unknown Object (File)
Wed, May 6, 2:38 PM
Unknown Object (File)
Sun, May 3, 4:24 PM
Unknown Object (File)
Tue, Apr 28, 4:43 AM
Unknown Object (File)
Tue, Apr 28, 4:33 AM
Unknown Object (File)
Tue, Apr 21, 1:59 PM
View All Files
Subscribers
trasz

Details

Reviewers
None
Group Reviewers
Linux Emulation
Commits
rS283436: Use the BSD_TO_LINUX_SIGNAL() wherever there is no need

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

dchagin updated this revision to Diff 2234.Nov 3 2014, 7:03 AM
dchagin retitled this revision from to Use the BSD_TO_LINUX_SIGNAL() wherever there is no need to check the ABI as it is known..
dchagin added a reviewer: Linux Emulation.Nov 3 2014, 9:06 AM
dchagin updated this revision to Diff 2316.Nov 6 2014, 9:26 PM

More BSD_TO_LINUX..

Updating D1086: Use the BSD_TO_LINUX_SIGNAL() wherever there is no need

to check the ABI as it is known.

trasz added a subscriber: trasz.Mar 25 2015, 1:34 PM

Where is BSD_TO_LINUX_SIGNAL() defined?

dchagin added a comment.Mar 25 2015, 7:10 PM
In D1086#5, @trasz wrote:

Where is BSD_TO_LINUX_SIGNAL() defined?

/compat/linux/linux_signal.h

trasz added inline comments.Mar 27 2015, 11:48 AM
sys/amd64/linux32/linux32_sysvec.c
347

Doesn't this macro miss check for sig > 0? If sig == 0, we end up dereferencing bsd_to_linux_signal[-1], right?

dchagin added inline comments.Mar 27 2015, 3:35 PM
sys/amd64/linux32/linux32_sysvec.c
347

in this context sig is always valid

Closed by commit rS283436: Use the BSD_TO_LINUX_SIGNAL() wherever there is no need (authored by dchagin). · Explain WhyMay 24 2015, 4:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
amd64/
linux32/
4 lines
8 lines
i386/
linux/
8 lines

Diff 2234

View Options

sys/amd64/linux32/linux32_machdep.c

Loading...
View Options

sys/amd64/linux32/linux32_sysvec.c

Loading...
View Options

sys/i386/linux/linux_sysvec.c

Loading...