Page MenuHomeFreeBSD
Differential D1086

Use the BSD_TO_LINUX_SIGNAL() wherever there is no need to check the ABI as it is known.
ClosedPublic
Actions

Authored by dchagin on Nov 3 2014, 7:03 AM.
Tags
None
Referenced Files
F133603335: D1086.diff
Sun, Oct 26, 11:27 PM
Unknown Object (File)
Fri, Oct 17, 11:12 PM
Unknown Object (File)
Sun, Oct 12, 12:22 PM
Unknown Object (File)
Sat, Oct 11, 2:23 AM
Unknown Object (File)
Thu, Oct 9, 2:07 PM
Unknown Object (File)
Sep 18 2025, 9:40 AM
Unknown Object (File)
Sep 15 2025, 6:41 AM
Unknown Object (File)
Sep 12 2025, 8:43 AM
View All Files
Subscribers
trasz

Details

Reviewers
None
Group Reviewers
Linux Emulation
Commits
rS283436: Use the BSD_TO_LINUX_SIGNAL() wherever there is no need

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dchagin updated this revision to Diff 2234.Nov 3 2014, 7:03 AM
dchagin retitled this revision from to Use the BSD_TO_LINUX_SIGNAL() wherever there is no need to check the ABI as it is known..
dchagin added a reviewer: Linux Emulation.Nov 3 2014, 9:06 AM
dchagin updated this revision to Diff 2316.Nov 6 2014, 9:26 PM

More BSD_TO_LINUX..

Updating D1086: Use the BSD_TO_LINUX_SIGNAL() wherever there is no need

to check the ABI as it is known.

trasz added a subscriber: trasz.Mar 25 2015, 1:34 PM

Where is BSD_TO_LINUX_SIGNAL() defined?

dchagin added a comment.Mar 25 2015, 7:10 PM
In D1086#5, @trasz wrote:

Where is BSD_TO_LINUX_SIGNAL() defined?

/compat/linux/linux_signal.h

trasz added inline comments.Mar 27 2015, 11:48 AM
sys/amd64/linux32/linux32_sysvec.c
347 ↗(On Diff #2316)

Doesn't this macro miss check for sig > 0? If sig == 0, we end up dereferencing bsd_to_linux_signal[-1], right?

dchagin added inline comments.Mar 27 2015, 3:35 PM
sys/amd64/linux32/linux32_sysvec.c
347 ↗(On Diff #2316)

in this context sig is always valid

Closed by commit rS283436: Use the BSD_TO_LINUX_SIGNAL() wherever there is no need (authored by dchagin). · Explain WhyMay 24 2015, 4:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
linux32/
8 lines
compat/
linux/
11 lines
i386/
linux/
8 lines

Diff 5643

View Options

head/sys/amd64/linux32/linux32_sysvec.c

Loading...
View Options

head/sys/compat/linux/linux_signal.c

Loading...
View Options

head/sys/i386/linux/linux_sysvec.c

Loading...