Page MenuHomeFreeBSD
Differential D8430

smb: fix SMB_READB, SMB_READW, SMB_PCALL to work as documented
ClosedPublic
Actions

Authored by avg on Nov 3 2016, 8:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 1:25 PM
Unknown Object (File)
Wed, Nov 6, 4:03 PM
Unknown Object (File)
Wed, Nov 6, 2:54 PM
Unknown Object (File)
Wed, Nov 6, 1:50 PM
Unknown Object (File)
Mon, Nov 4, 9:47 PM
Unknown Object (File)
Mon, Nov 4, 9:47 PM
Unknown Object (File)
Mon, Nov 4, 9:47 PM
Unknown Object (File)
Mon, Nov 4, 9:47 PM
View All Files
Subscribers
lew_perftech.com

Details

Reviewers
jhb
grembo
lew_perftech.com
imp
Commits
rS308527: smb: fix SMB_READB, SMB_READW, SMB_PCALL to work as documented
Summary

Previously, those ioctls were defined as 'in' only, so rdata.byte and
rdata.word were never updated in the userland. The read data went only
to rbuf if it was provided. Thus, consumers were forced to always use it.

Now the ioctls are marked as in-out.
Compatibility handlers are provided for old ioctls.

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213481
Reported by: Lewis Donzis <lew@perftech.com>
https://lists.freebsd.org/pipermail/freebsd-bugs/2016-October/070348.html

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5827
Build 6116: arc lint + arc unit

Event Timeline

avg updated this revision to Diff 21964.Nov 3 2016, 8:09 AM
avg retitled this revision from to smb: fix SMB_READB, SMB_READW, SMB_PCALL to work as documented.
avg updated this object.
avg edited the test plan for this revision. (Show Details)
avg added reviewers: grembo, imp, jhb.
avg updated this revision to Diff 21965.Nov 3 2016, 8:12 AM
  • make compatibility ioctl defintions private
  • remove unused macro
avg updated this object.Nov 3 2016, 8:19 AM
lew_perftech.com accepted this revision.Nov 10 2016, 1:33 PM
lew_perftech.com added a reviewer: lew_perftech.com.
lew_perftech.com added a subscriber: lew_perftech.com.

Looks good to me, thanks.

This revision is now accepted and ready to land.Nov 10 2016, 1:33 PM
Closed by commit rS308527: smb: fix SMB_READB, SMB_READW, SMB_PCALL to work as documented (authored by avg). · Explain WhyNov 11 2016, 2:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
smbus/
10 lines
6 lines

Diff 21964

View Options

sys/dev/smbus/smb.h

Loading...
View Options

sys/dev/smbus/smb.c

Loading...